rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-02-18 22:25:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #302 from mathuo/230-explore-floating-groups

Browse Source 
230 explore floating groups
This commit is contained in:
mathuo 2023-07-16 19:56:10 +01:00 committed by GitHub
commit 7f5f34d6f2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/dockview-core/src/dockview/components/tab/tab.ts
View File

@ -80,14 +80,6 @@ export class Tab extends CompositeDisposable implements ITab {
return; return;
} }
/**
* TODO: alternative to stopPropagation
*
* I need to stop the event propagation here since otherwise it'll be intercepted by event handlers
* on the tabs-container. I cannot use event.preventDefault() since I need the on DragStart event to occur
*/
event.stopPropagation();
this._onChanged.fire(event); this._onChanged.fire(event);
}) })
); );

1
packages/dockview-core/src/dockview/components/titlebar/voidContainer.ts
View File

@ -28,7 +28,6 @@ export class VoidContainer extends CompositeDisposable {
this._element = document.createElement('div'); this._element = document.createElement('div');
this._element.className = 'void-container'; this._element.className = 'void-container';
this._element.id = 'dv-group-float-drag-handle';
this._element.tabIndex = 0; this._element.tabIndex = 0;
this._element.draggable = true; this._element.draggable = true;

6
packages/dockview-core/src/dockview/dockviewComponent.ts
View File

@ -351,16 +351,12 @@ export class DockviewComponent
minimumInViewportHeight: 100, minimumInViewportHeight: 100,
}); });
const el = group.element.querySelector('#dv-group-float-drag-handle'); overlay.setupDrag(group.element, {
if (el) {
overlay.setupDrag(el as HTMLElement, {
inDragMode: inDragMode:
typeof options?.inDragMode === 'boolean' typeof options?.inDragMode === 'boolean'
? options.inDragMode ? options.inDragMode
: false, : false,
}); });
}
const floatingGroupPanel = new DockviewFloatingGroupPanel( const floatingGroupPanel = new DockviewFloatingGroupPanel(
group, group,