diff --git a/packages/dockview-core/src/dockview/components/tab/tab.ts b/packages/dockview-core/src/dockview/components/tab/tab.ts index b57d08b26..b8d86cabc 100644 --- a/packages/dockview-core/src/dockview/components/tab/tab.ts +++ b/packages/dockview-core/src/dockview/components/tab/tab.ts @@ -80,14 +80,6 @@ export class Tab extends CompositeDisposable implements ITab { return; } - /** - * TODO: alternative to stopPropagation - * - * I need to stop the event propagation here since otherwise it'll be intercepted by event handlers - * on the tabs-container. I cannot use event.preventDefault() since I need the on DragStart event to occur - */ - event.stopPropagation(); - this._onChanged.fire(event); }) ); diff --git a/packages/dockview-core/src/dockview/components/titlebar/voidContainer.ts b/packages/dockview-core/src/dockview/components/titlebar/voidContainer.ts index 5aef855c6..1737c87aa 100644 --- a/packages/dockview-core/src/dockview/components/titlebar/voidContainer.ts +++ b/packages/dockview-core/src/dockview/components/titlebar/voidContainer.ts @@ -28,7 +28,6 @@ export class VoidContainer extends CompositeDisposable { this._element = document.createElement('div'); this._element.className = 'void-container'; - this._element.id = 'dv-group-float-drag-handle'; this._element.tabIndex = 0; this._element.draggable = true; diff --git a/packages/dockview-core/src/dockview/dockviewComponent.ts b/packages/dockview-core/src/dockview/dockviewComponent.ts index 1bc5158cb..5906af6a4 100644 --- a/packages/dockview-core/src/dockview/dockviewComponent.ts +++ b/packages/dockview-core/src/dockview/dockviewComponent.ts @@ -351,16 +351,12 @@ export class DockviewComponent minimumInViewportHeight: 100, }); - const el = group.element.querySelector('#dv-group-float-drag-handle'); - - if (el) { - overlay.setupDrag(el as HTMLElement, { - inDragMode: - typeof options?.inDragMode === 'boolean' - ? options.inDragMode - : false, - }); - } + overlay.setupDrag(group.element, { + inDragMode: + typeof options?.inDragMode === 'boolean' + ? options.inDragMode + : false, + }); const floatingGroupPanel = new DockviewFloatingGroupPanel( group,