bug: close popout window if unloaded

This commit is contained in:
mathuo 2024-10-09 22:16:27 +01:00
parent bc455265cd
commit 7ddb63383f
No known key found for this signature in database
GPG Key ID: C6EEDEFD6CA07281

View File

@ -1,6 +1,6 @@
import { addStyles } from './dom'; import { addStyles } from './dom';
import { Emitter, addDisposableWindowListener } from './events'; import { Emitter, addDisposableWindowListener } from './events';
import { CompositeDisposable, IDisposable } from './lifecycle'; import { CompositeDisposable, Disposable, IDisposable } from './lifecycle';
import { Box } from './types'; import { Box } from './types';
export type PopoutWindowOptions = { export type PopoutWindowOptions = {
@ -99,6 +99,9 @@ export class PopoutWindow extends CompositeDisposable {
this._window = { value: externalWindow, disposable }; this._window = { value: externalWindow, disposable };
disposable.addDisposables( disposable.addDisposables(
Disposable.from(() => {
externalWindow.close();
}),
addDisposableWindowListener(window, 'beforeunload', () => { addDisposableWindowListener(window, 'beforeunload', () => {
/** /**
* before the main window closes we should close this popup too * before the main window closes we should close this popup too