From 7ddb63383f8efe8f18cbae43e8da0e29948ece26 Mon Sep 17 00:00:00 2001
From: mathuo <6710312+mathuo@users.noreply.github.com>
Date: Wed, 9 Oct 2024 22:16:27 +0100
Subject: [PATCH] bug: close popout window if unloaded

---
 packages/dockview-core/src/popoutWindow.ts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/packages/dockview-core/src/popoutWindow.ts b/packages/dockview-core/src/popoutWindow.ts
index b289ba645..14564cdef 100644
--- a/packages/dockview-core/src/popoutWindow.ts
+++ b/packages/dockview-core/src/popoutWindow.ts
@@ -1,6 +1,6 @@
 import { addStyles } from './dom';
 import { Emitter, addDisposableWindowListener } from './events';
-import { CompositeDisposable, IDisposable } from './lifecycle';
+import { CompositeDisposable, Disposable, IDisposable } from './lifecycle';
 import { Box } from './types';
 
 export type PopoutWindowOptions = {
@@ -99,6 +99,9 @@ export class PopoutWindow extends CompositeDisposable {
         this._window = { value: externalWindow, disposable };
 
         disposable.addDisposables(
+            Disposable.from(() => {
+                externalWindow.close();
+            }),
             addDisposableWindowListener(window, 'beforeunload', () => {
                 /**
                  * before the main window closes we should close this popup too