rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-05-06 11:38:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove dead code

Browse Source
This commit is contained in:
mathuo 2023-02-12 21:12:14 +07:00
parent fa5cf06431
commit 716424d972
No known key found for this signature in database
GPG Key ID: C6EEDEFD6CA07281
2 changed files with 14 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
packages/dockview/src/groupview/tab.ts
View File

@ -14,22 +14,11 @@ import { DroptargetEvent, Droptarget } from '../dnd/droptarget';
import { DockviewDropTargets } from './dnd'; import { DockviewDropTargets } from './dnd';
import { DragHandler } from '../dnd/abstractDragHandler'; import { DragHandler } from '../dnd/abstractDragHandler';
export enum MouseEventKind {
CLICK = 'CLICK',
}
export interface LayoutMouseEvent {
readonly kind: MouseEventKind;
readonly event: MouseEvent;
readonly panel?: IDockviewPanel;
readonly tab?: boolean;
}
export interface ITab { export interface ITab {
readonly panelId: string; readonly panelId: string;
readonly element: HTMLElement; readonly element: HTMLElement;
setContent: (element: ITabRenderer) => void; setContent: (element: ITabRenderer) => void;
onChanged: Event<LayoutMouseEvent>; onChanged: Event<MouseEvent>;
onDrop: Event<DroptargetEvent>; onDrop: Event<DroptargetEvent>;
setActive(isActive: boolean): void; setActive(isActive: boolean): void;
} }
@ -39,13 +28,13 @@ export class Tab extends CompositeDisposable implements ITab {
private readonly droptarget: Droptarget; private readonly droptarget: Droptarget;
private content?: ITabRenderer; private content?: ITabRenderer;
private readonly _onChanged = new Emitter<LayoutMouseEvent>(); private readonly _onChanged = new Emitter<MouseEvent>();
readonly onChanged: Event<LayoutMouseEvent> = this._onChanged.event; readonly onChanged: Event<MouseEvent> = this._onChanged.event;
private readonly _onDropped = new Emitter<DroptargetEvent>(); private readonly _onDropped = new Emitter<DroptargetEvent>();
readonly onDrop: Event<DroptargetEvent> = this._onDropped.event; readonly onDrop: Event<DroptargetEvent> = this._onDropped.event;
public get element() { public get element(): HTMLElement {
return this._element; return this._element;
} }
@ -104,7 +93,7 @@ export class Tab extends CompositeDisposable implements ITab {
*/ */
event.stopPropagation(); event.stopPropagation();
this._onChanged.fire({ kind: MouseEventKind.CLICK, event }); this._onChanged.fire(event);
}) })
); );
@ -135,12 +124,12 @@ export class Tab extends CompositeDisposable implements ITab {
); );
} }
public setActive(isActive: boolean) { public setActive(isActive: boolean): void {
toggleClass(this.element, 'active-tab', isActive); toggleClass(this.element, 'active-tab', isActive);
toggleClass(this.element, 'inactive-tab', !isActive); toggleClass(this.element, 'inactive-tab', !isActive);
} }
public setContent(part: ITabRenderer) { public setContent(part: ITabRenderer): void {
if (this.content) { if (this.content) {
this._element.removeChild(this.content.element); this._element.removeChild(this.content.element);
} }
@ -148,7 +137,7 @@ export class Tab extends CompositeDisposable implements ITab {
this._element.appendChild(this.content.element); this._element.appendChild(this.content.element);
} }
public dispose() { public dispose(): void {
super.dispose(); super.dispose();
this.droptarget.dispose(); this.droptarget.dispose();
} }

8
packages/dockview/src/groupview/titlebar/tabsContainer.ts
View File

@ -4,7 +4,7 @@ import {
IValueDisposable, IValueDisposable,
} from '../../lifecycle'; } from '../../lifecycle';
import { addDisposableListener, Emitter, Event } from '../../events'; import { addDisposableListener, Emitter, Event } from '../../events';
import { ITab, MouseEventKind, Tab } from '../tab'; import { ITab, Tab } from '../tab';
import { IDockviewPanel } from '../groupPanel'; import { IDockviewPanel } from '../groupPanel';
import { DockviewComponent } from '../../dockview/dockviewComponent'; import { DockviewComponent } from '../../dockview/dockviewComponent';
import { GroupPanel } from '../groupviewPanel'; import { GroupPanel } from '../groupviewPanel';
@ -256,17 +256,15 @@ export class TabsContainer
panel.id === this.group.model.activePanel?.id && panel.id === this.group.model.activePanel?.id &&
this.group.model.isContentFocused; this.group.model.isContentFocused;
const isLeftClick = event.event.button === 0; const isLeftClick = event.button === 0;
if (!isLeftClick || event.event.defaultPrevented) { if (!isLeftClick || event.defaultPrevented) {
return; return;
} }
if (event.kind === MouseEventKind.CLICK) {
this.group.model.openPanel(panel, { this.group.model.openPanel(panel, {
skipFocus: alreadyFocused, skipFocus: alreadyFocused,
}); });
}
}), }),
tabToAdd.onDrop((event) => { tabToAdd.onDrop((event) => {
this._onDrop.fire({ this._onDrop.fire({