From 716424d97237c93c1bee3c684e313993c7eb4200 Mon Sep 17 00:00:00 2001
From: mathuo <6710312+mathuo@users.noreply.github.com>
Date: Sun, 12 Feb 2023 21:12:14 +0700
Subject: [PATCH] refactor: remove dead code

---
 packages/dockview/src/groupview/tab.ts        | 27 ++++++-------------
 .../src/groupview/titlebar/tabsContainer.ts   | 14 +++++-----
 2 files changed, 14 insertions(+), 27 deletions(-)

diff --git a/packages/dockview/src/groupview/tab.ts b/packages/dockview/src/groupview/tab.ts
index d0d902370..24ce1457c 100644
--- a/packages/dockview/src/groupview/tab.ts
+++ b/packages/dockview/src/groupview/tab.ts
@@ -14,22 +14,11 @@ import { DroptargetEvent, Droptarget } from '../dnd/droptarget';
 import { DockviewDropTargets } from './dnd';
 import { DragHandler } from '../dnd/abstractDragHandler';
 
-export enum MouseEventKind {
-    CLICK = 'CLICK',
-}
-
-export interface LayoutMouseEvent {
-    readonly kind: MouseEventKind;
-    readonly event: MouseEvent;
-    readonly panel?: IDockviewPanel;
-    readonly tab?: boolean;
-}
-
 export interface ITab {
     readonly panelId: string;
     readonly element: HTMLElement;
     setContent: (element: ITabRenderer) => void;
-    onChanged: Event<LayoutMouseEvent>;
+    onChanged: Event<MouseEvent>;
     onDrop: Event<DroptargetEvent>;
     setActive(isActive: boolean): void;
 }
@@ -39,13 +28,13 @@ export class Tab extends CompositeDisposable implements ITab {
     private readonly droptarget: Droptarget;
     private content?: ITabRenderer;
 
-    private readonly _onChanged = new Emitter<LayoutMouseEvent>();
-    readonly onChanged: Event<LayoutMouseEvent> = this._onChanged.event;
+    private readonly _onChanged = new Emitter<MouseEvent>();
+    readonly onChanged: Event<MouseEvent> = this._onChanged.event;
 
     private readonly _onDropped = new Emitter<DroptargetEvent>();
     readonly onDrop: Event<DroptargetEvent> = this._onDropped.event;
 
-    public get element() {
+    public get element(): HTMLElement {
         return this._element;
     }
 
@@ -104,7 +93,7 @@ export class Tab extends CompositeDisposable implements ITab {
                  */
                 event.stopPropagation();
 
-                this._onChanged.fire({ kind: MouseEventKind.CLICK, event });
+                this._onChanged.fire(event);
             })
         );
 
@@ -135,12 +124,12 @@ export class Tab extends CompositeDisposable implements ITab {
         );
     }
 
-    public setActive(isActive: boolean) {
+    public setActive(isActive: boolean): void {
         toggleClass(this.element, 'active-tab', isActive);
         toggleClass(this.element, 'inactive-tab', !isActive);
     }
 
-    public setContent(part: ITabRenderer) {
+    public setContent(part: ITabRenderer): void {
         if (this.content) {
             this._element.removeChild(this.content.element);
         }
@@ -148,7 +137,7 @@ export class Tab extends CompositeDisposable implements ITab {
         this._element.appendChild(this.content.element);
     }
 
-    public dispose() {
+    public dispose(): void {
         super.dispose();
         this.droptarget.dispose();
     }
diff --git a/packages/dockview/src/groupview/titlebar/tabsContainer.ts b/packages/dockview/src/groupview/titlebar/tabsContainer.ts
index 192489250..667d0f298 100644
--- a/packages/dockview/src/groupview/titlebar/tabsContainer.ts
+++ b/packages/dockview/src/groupview/titlebar/tabsContainer.ts
@@ -4,7 +4,7 @@ import {
     IValueDisposable,
 } from '../../lifecycle';
 import { addDisposableListener, Emitter, Event } from '../../events';
-import { ITab, MouseEventKind, Tab } from '../tab';
+import { ITab, Tab } from '../tab';
 import { IDockviewPanel } from '../groupPanel';
 import { DockviewComponent } from '../../dockview/dockviewComponent';
 import { GroupPanel } from '../groupviewPanel';
@@ -256,17 +256,15 @@ export class TabsContainer
                     panel.id === this.group.model.activePanel?.id &&
                     this.group.model.isContentFocused;
 
-                const isLeftClick = event.event.button === 0;
+                const isLeftClick = event.button === 0;
 
-                if (!isLeftClick || event.event.defaultPrevented) {
+                if (!isLeftClick || event.defaultPrevented) {
                     return;
                 }
 
-                if (event.kind === MouseEventKind.CLICK) {
-                    this.group.model.openPanel(panel, {
-                        skipFocus: alreadyFocused,
-                    });
-                }
+                this.group.model.openPanel(panel, {
+                    skipFocus: alreadyFocused,
+                });
             }),
             tabToAdd.onDrop((event) => {
                 this._onDrop.fire({