bug: wrong event ordering

This commit is contained in:
mathuo 2024-12-09 19:40:49 +00:00
parent 25489bf48e
commit 56bdec846c
No known key found for this signature in database
GPG Key ID: C6EEDEFD6CA07281

View File

@ -659,20 +659,23 @@ export class DockviewComponent
const isGroupAddedToDom =
referenceGroup.element.parentElement !== null;
const group = !isGroupAddedToDom
? referenceGroup
: options?.overridePopoutGroup ??
this.createGroup({ id: groupId });
let group: DockviewGroupPanel;
if (!isGroupAddedToDom) {
group = referenceGroup;
} else if (options?.overridePopoutGroup) {
group = options.overridePopoutGroup;
} else {
group = this.createGroup({ id: groupId });
this._onDidAddGroup.fire(group);
}
group.model.renderContainer = overlayRenderContainer;
group.layout(
_window.window!.innerWidth,
_window.window!.innerHeight
);
if (!this._groups.has(group.api.id)) {
this._onDidAddGroup.fire(group);
}
if (!options?.overridePopoutGroup && isGroupAddedToDom) {
if (itemToPopout instanceof DockviewPanel) {
this.movingLock(() => {