diff --git a/packages/dockview-core/src/dockview/dockviewComponent.ts b/packages/dockview-core/src/dockview/dockviewComponent.ts index 5a20f5b84..c1899e7f0 100644 --- a/packages/dockview-core/src/dockview/dockviewComponent.ts +++ b/packages/dockview-core/src/dockview/dockviewComponent.ts @@ -659,20 +659,23 @@ export class DockviewComponent const isGroupAddedToDom = referenceGroup.element.parentElement !== null; - const group = !isGroupAddedToDom - ? referenceGroup - : options?.overridePopoutGroup ?? - this.createGroup({ id: groupId }); + let group: DockviewGroupPanel; + + if (!isGroupAddedToDom) { + group = referenceGroup; + } else if (options?.overridePopoutGroup) { + group = options.overridePopoutGroup; + } else { + group = this.createGroup({ id: groupId }); + this._onDidAddGroup.fire(group); + } + group.model.renderContainer = overlayRenderContainer; group.layout( _window.window!.innerWidth, _window.window!.innerHeight ); - if (!this._groups.has(group.api.id)) { - this._onDidAddGroup.fire(group); - } - if (!options?.overridePopoutGroup && isGroupAddedToDom) { if (itemToPopout instanceof DockviewPanel) { this.movingLock(() => {