Adding comments explaining why we don't use GTest's built in stacktraces. Also removed an unused header from stacktrace_handler.cc.
PiperOrigin-RevId: 263659753
This commit is contained in:
parent
4a186b5ed4
commit
ada854ed47
@ -804,7 +804,6 @@ cc_library(
|
||||
hdrs = ["//tensorflow/core/platform:stacktrace_handler.h"],
|
||||
deps = [
|
||||
"//tensorflow/core/platform",
|
||||
"//tensorflow/core/platform:abi",
|
||||
"//tensorflow/core/platform:stacktrace",
|
||||
],
|
||||
)
|
||||
|
@ -30,7 +30,6 @@ limitations under the License.
|
||||
#include <unistd.h>
|
||||
#include <string>
|
||||
|
||||
#include "tensorflow/core/platform/abi.h"
|
||||
#include "tensorflow/core/platform/stacktrace.h"
|
||||
|
||||
#endif // defined(TF_GENERATE_STACKTRACE)
|
||||
|
@ -20,6 +20,9 @@ namespace tensorflow {
|
||||
namespace testing {
|
||||
|
||||
// Installs signal handlers to print out stack trace.
|
||||
// Although GoogleTest has support for generating stacktraces with abseil via
|
||||
// https://github.com/google/googletest/pull/1653, this doesn't cover our use
|
||||
// case of getting C++ stacktraces in our python tests.
|
||||
void InstallStacktraceHandler();
|
||||
|
||||
} // namespace testing
|
||||
|
Loading…
x
Reference in New Issue
Block a user