From ada854ed4783536e85b776572b63ba37bad114e0 Mon Sep 17 00:00:00 2001 From: Brian Zhao Date: Thu, 15 Aug 2019 15:54:16 -0700 Subject: [PATCH] Adding comments explaining why we don't use GTest's built in stacktraces. Also removed an unused header from stacktrace_handler.cc. PiperOrigin-RevId: 263659753 --- tensorflow/core/BUILD | 1 - tensorflow/core/platform/stacktrace_handler.cc | 1 - tensorflow/core/platform/stacktrace_handler.h | 3 +++ 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tensorflow/core/BUILD b/tensorflow/core/BUILD index 190319ff561..5e77577c614 100644 --- a/tensorflow/core/BUILD +++ b/tensorflow/core/BUILD @@ -804,7 +804,6 @@ cc_library( hdrs = ["//tensorflow/core/platform:stacktrace_handler.h"], deps = [ "//tensorflow/core/platform", - "//tensorflow/core/platform:abi", "//tensorflow/core/platform:stacktrace", ], ) diff --git a/tensorflow/core/platform/stacktrace_handler.cc b/tensorflow/core/platform/stacktrace_handler.cc index ff31c97be0a..19fd4a31a65 100644 --- a/tensorflow/core/platform/stacktrace_handler.cc +++ b/tensorflow/core/platform/stacktrace_handler.cc @@ -30,7 +30,6 @@ limitations under the License. #include #include -#include "tensorflow/core/platform/abi.h" #include "tensorflow/core/platform/stacktrace.h" #endif // defined(TF_GENERATE_STACKTRACE) diff --git a/tensorflow/core/platform/stacktrace_handler.h b/tensorflow/core/platform/stacktrace_handler.h index 9f118b91b85..aafafc821ad 100644 --- a/tensorflow/core/platform/stacktrace_handler.h +++ b/tensorflow/core/platform/stacktrace_handler.h @@ -20,6 +20,9 @@ namespace tensorflow { namespace testing { // Installs signal handlers to print out stack trace. +// Although GoogleTest has support for generating stacktraces with abseil via +// https://github.com/google/googletest/pull/1653, this doesn't cover our use +// case of getting C++ stacktraces in our python tests. void InstallStacktraceHandler(); } // namespace testing