Revert "Revert "Set --incompatible_remove_legacy_whole_archive to False""

This commit is contained in:
Mihai Maruseac 2019-12-20 11:35:16 -08:00 committed by GitHub
parent 3b9a26c2b5
commit 4bb06cece2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -137,8 +137,19 @@ build --announce_rc
# Other build flags.
build --define=grpc_no_ares=true
# Prevent regression of https://github.com/bazelbuild/bazel/issues/7362
build --incompatible_remove_legacy_whole_archive
# See https://github.com/bazelbuild/bazel/issues/7362 for information on what
# --incompatible_remove_legacy_whole_archive flag does.
# This flag is set to true in Bazel 1.0 and newer versions. We tried to migrate
# Tensorflow to the default, however test coverage wasn't enough to catch the
# errors.
# There is ongoing work on Bazel team's side to provide support for transitive
# shared libraries. As part of migrating to transitive shared libraries, we
# hope to provide a better mechanism for control over symbol exporting, and
# then tackle this issue again.
#
# TODO: Remove this line once TF doesn't depend on Bazel wrapping all library
# archives in -whole_archive -no_whole_archive.
build --noincompatible_remove_legacy_whole_archive
# Modular TF build options
build:dynamic_kernels --define=dynamic_loaded_kernels=true