From 4bb06cece2607b0106c137dcc8b24ae81292ca0d Mon Sep 17 00:00:00 2001 From: Mihai Maruseac Date: Fri, 20 Dec 2019 11:35:16 -0800 Subject: [PATCH] Revert "Revert "Set --incompatible_remove_legacy_whole_archive to False"" --- .bazelrc | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/.bazelrc b/.bazelrc index 638bb39fafd..9aca8b4261e 100644 --- a/.bazelrc +++ b/.bazelrc @@ -137,8 +137,19 @@ build --announce_rc # Other build flags. build --define=grpc_no_ares=true -# Prevent regression of https://github.com/bazelbuild/bazel/issues/7362 -build --incompatible_remove_legacy_whole_archive +# See https://github.com/bazelbuild/bazel/issues/7362 for information on what +# --incompatible_remove_legacy_whole_archive flag does. +# This flag is set to true in Bazel 1.0 and newer versions. We tried to migrate +# Tensorflow to the default, however test coverage wasn't enough to catch the +# errors. +# There is ongoing work on Bazel team's side to provide support for transitive +# shared libraries. As part of migrating to transitive shared libraries, we +# hope to provide a better mechanism for control over symbol exporting, and +# then tackle this issue again. +# +# TODO: Remove this line once TF doesn't depend on Bazel wrapping all library +# archives in -whole_archive -no_whole_archive. +build --noincompatible_remove_legacy_whole_archive # Modular TF build options build:dynamic_kernels --define=dynamic_loaded_kernels=true