Make subscription::Recipe cross-platform

By removing the `Send` requirement when targetting Wasm
This commit is contained in:
Héctor Ramón Jiménez 2020-03-26 14:55:02 +01:00
parent 138110f596
commit 338fff35ac
3 changed files with 22 additions and 26 deletions

View File

@ -3,7 +3,7 @@ mod tracker;
pub use tracker::Tracker; pub use tracker::Tracker;
use futures::stream::BoxStream; use crate::BoxStream;
/// A request to listen to external events. /// A request to listen to external events.
/// ///
@ -168,8 +168,8 @@ pub trait Recipe<Hasher: std::hash::Hasher, Event> {
/// [`Recipe`]: trait.Recipe.html /// [`Recipe`]: trait.Recipe.html
fn stream( fn stream(
self: Box<Self>, self: Box<Self>,
input: BoxStream<'static, Event>, input: BoxStream<Event>,
) -> BoxStream<'static, Self::Output>; ) -> BoxStream<Self::Output>;
} }
struct Map<Hasher, Event, A, B> { struct Map<Hasher, Event, A, B> {
@ -201,18 +201,16 @@ where
self.recipe.hash(state); self.recipe.hash(state);
} }
fn stream( fn stream(self: Box<Self>, input: BoxStream<E>) -> BoxStream<Self::Output> {
self: Box<Self>,
input: BoxStream<'static, E>,
) -> futures::stream::BoxStream<'static, Self::Output> {
use futures::StreamExt; use futures::StreamExt;
let mapper = self.mapper; let mapper = self.mapper;
self.recipe Box::pin(
.stream(input) self.recipe
.map(move |element| mapper(element)) .stream(input)
.boxed() .map(move |element| mapper(element)),
)
} }
} }
@ -243,17 +241,15 @@ where
self.recipe.hash(state); self.recipe.hash(state);
} }
fn stream( fn stream(self: Box<Self>, input: BoxStream<E>) -> BoxStream<Self::Output> {
self: Box<Self>,
input: BoxStream<'static, E>,
) -> futures::stream::BoxStream<'static, Self::Output> {
use futures::StreamExt; use futures::StreamExt;
let value = self.value; let value = self.value;
self.recipe Box::pin(
.stream(input) self.recipe
.map(move |element| (value.clone(), element)) .stream(input)
.boxed() .map(move |element| (value.clone(), element)),
)
} }
} }

View File

@ -1,6 +1,6 @@
use crate::Subscription; use crate::{BoxFuture, Subscription};
use futures::{channel::mpsc, future::BoxFuture, sink::Sink}; use futures::{channel::mpsc, sink::Sink};
use std::{collections::HashMap, marker::PhantomData}; use std::{collections::HashMap, marker::PhantomData};
/// A registry of subscription streams. /// A registry of subscription streams.
@ -59,7 +59,7 @@ where
&mut self, &mut self,
subscription: Subscription<Hasher, Event, Message>, subscription: Subscription<Hasher, Event, Message>,
receiver: Receiver, receiver: Receiver,
) -> Vec<BoxFuture<'static, ()>> ) -> Vec<BoxFuture<()>>
where where
Message: 'static + Send, Message: 'static + Send,
Receiver: 'static Receiver: 'static
@ -70,7 +70,7 @@ where
{ {
use futures::{future::FutureExt, stream::StreamExt}; use futures::{future::FutureExt, stream::StreamExt};
let mut futures = Vec::new(); let mut futures: Vec<BoxFuture<()>> = Vec::new();
let recipes = subscription.recipes(); let recipes = subscription.recipes();
let mut alive = std::collections::HashSet::new(); let mut alive = std::collections::HashSet::new();
@ -115,7 +115,7 @@ where
}, },
); );
futures.push(future.boxed()); futures.push(Box::pin(future));
} }
self.subscriptions.retain(|id, _| alive.contains(&id)); self.subscriptions.retain(|id, _| alive.contains(&id));

View File

@ -2,7 +2,7 @@ use crate::{
subscription::{EventStream, Recipe}, subscription::{EventStream, Recipe},
Event, Hasher, Event, Hasher,
}; };
use iced_futures::futures::stream::BoxStream; use iced_futures::BoxStream;
pub struct Events; pub struct Events;
@ -18,7 +18,7 @@ impl Recipe<Hasher, Event> for Events {
fn stream( fn stream(
self: Box<Self>, self: Box<Self>,
event_stream: EventStream, event_stream: EventStream,
) -> BoxStream<'static, Self::Output> { ) -> BoxStream<Self::Output> {
event_stream event_stream
} }
} }