From 21b583c46899d8f31ea39ede7194abf6f61df636 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?H=C3=A9ctor=20Ram=C3=B3n=20Jim=C3=A9nez?=
 <hector0193@gmail.com>
Date: Wed, 8 Jul 2020 08:25:56 +0200
Subject: [PATCH] Avoid reopening `Menu` in `ComboBox`

---
 native/src/widget/combo_box.rs | 28 ++++++++++++++++++----------
 1 file changed, 18 insertions(+), 10 deletions(-)

diff --git a/native/src/widget/combo_box.rs b/native/src/widget/combo_box.rs
index 4d020c3b..9447b9dd 100644
--- a/native/src/widget/combo_box.rs
+++ b/native/src/widget/combo_box.rs
@@ -19,6 +19,7 @@ where
     text_size: Option<u16>,
     font: Renderer::Font,
     style: <Renderer as self::Renderer>::Style,
+    is_open: bool,
 }
 
 #[derive(Default)]
@@ -38,6 +39,8 @@ where
         selected: Option<T>,
         on_selected: impl Fn(T) -> Message + 'static,
     ) -> Self {
+        let is_open = state.menu.is_open();
+
         Self {
             menu: &mut state.menu,
             on_selected: Box::new(on_selected),
@@ -48,6 +51,7 @@ where
             padding: Renderer::DEFAULT_PADDING,
             font: Default::default(),
             style: Default::default(),
+            is_open,
         }
     }
 
@@ -179,19 +183,23 @@ where
         _renderer: &Renderer,
         _clipboard: Option<&dyn Clipboard>,
     ) {
-        match event {
-            Event::Mouse(mouse::Event::ButtonPressed(mouse::Button::Left)) => {
-                if layout.bounds().contains(cursor_position) {
-                    let selected = self.selected.as_ref();
+        if !self.is_open {
+            match event {
+                Event::Mouse(mouse::Event::ButtonPressed(
+                    mouse::Button::Left,
+                )) => {
+                    if layout.bounds().contains(cursor_position) {
+                        let selected = self.selected.as_ref();
 
-                    self.menu.open(
-                        self.options
-                            .iter()
-                            .position(|option| Some(option) == selected),
-                    );
+                        self.menu.open(
+                            self.options
+                                .iter()
+                                .position(|option| Some(option) == selected),
+                        );
+                    }
                 }
+                _ => {}
             }
-            _ => {}
         }
     }