Additional code cleanup for Codacy

src/api/controllers/Invalid.php

@@ -2,13 +2,16 @@
 class Invalid extends BaseController {
 
     public function noApi($request, $response) {
+        $request; // Not used, but required for Slim Framework
         $this->apiJson->addAlert('error',
             'No API functionality at this endpoint.');
 
         $apiReturn = new stdClass();
         $apiReturn->status = 'One of "success" or "failure".';
-        $apiReturn->data = 'An array of data (JSON objects and/or arrays). The first object is a new JWT for the next request.';
-        $apiReturn->alerts = 'An array of alerts, with "type" of "success", "error", "warn", or "info" and a "text" message.';
+        $apiReturn->data = 'An array of data (JSON objects and/or arrays). ' .
+            'The first object is a new JWT for the next request.';
+        $apiReturn->alerts = 'An array of alerts, with "type" of "success", ' .
+            '"error", "warn", or "info" and a "text" message.';
 
         $this->apiJson->addData($apiReturn);
 

src/scss/_chartist-settings.scss

@@ -17,7 +17,7 @@ $ct-text-color: $color-text;
     position: absolute;
     transition: opacity .2s;
 
-    &:before {
+    &::before {
         border: 10px solid transparent;
         border-top-color: $color-text;
         content: '';

src/scss/_core.scss

@@ -104,7 +104,7 @@ button {
 .icon-help-circled {
     position: relative;
 
-    &:hover:after {
+    &:hover::after {
         @include shadow-high;
 
         background-color: $white;

src/scss/_icons.scss

@@ -22,27 +22,27 @@
     width: 1em;
 }
 
-.icon-trash-empty:before { content: '\e800'; }
-.icon-edit:before { content: '\e801'; }
-.icon-plus:before { content: '\e802'; }
-.icon-help-circled:before { content: '\e803'; }
-.icon-cancel:before { content: '\e804'; }
-.icon-download:before { content: '\e805'; }
-.icon-upload:before { content: '\e806'; }
-.icon-eye:before { content: '\e807'; }
-.icon-comment-empty:before { content: '\e808'; }
-.icon-chat-empty:before { content: '\e809'; }
-.icon-attach:before { content: '\e80a'; }
-.icon-angle-double-left:before { content: '\e80b'; }
-.icon-angle-double-right:before { content: '\e80c'; }
-.icon-angle-double-down:before { content: '\e80d'; }
-.icon-angle-double-up:before { content: '\e80e'; }
-.icon-calendar:before { content: '\e80f'; }
-.icon-floppy:before { content: '\e810'; }
-.icon-resize-vertical:before { content: '\e811'; }
-.icon-minus-squared-alt:before { content: '\f147'; }
-.icon-plus-squared-alt:before { content: '\f196'; }
-.icon-eyedropper:before { content: '\f1fb'; }
+.icon-trash-empty::before { content: '\e800'; }
+.icon-edit::before { content: '\e801'; }
+.icon-plus::before { content: '\e802'; }
+.icon-help-circled::before { content: '\e803'; }
+.icon-cancel::before { content: '\e804'; }
+.icon-download::before { content: '\e805'; }
+.icon-upload::before { content: '\e806'; }
+.icon-eye::before { content: '\e807'; }
+.icon-comment-empty::before { content: '\e808'; }
+.icon-chat-empty::before { content: '\e809'; }
+.icon-attach::before { content: '\e80a'; }
+.icon-angle-double-left::before { content: '\e80b'; }
+.icon-angle-double-right::before { content: '\e80c'; }
+.icon-angle-double-down::before { content: '\e80d'; }
+.icon-angle-double-up::before { content: '\e80e'; }
+.icon-calendar::before { content: '\e80f'; }
+.icon-floppy::before { content: '\e810'; }
+.icon-resize-vertical::before { content: '\e811'; }
+.icon-minus-squared-alt::before { content: '\f147'; }
+.icon-plus-squared-alt::before { content: '\f196'; }
+.icon-eyedropper::before { content: '\f1fb'; }
 
 .icon-help-circled {
     cursor: help;

src/scss/_login.scss

@@ -42,8 +42,8 @@
         margin-bottom: -1em;
     }
 
-    &:before,
-    &:after {
+    &::before,
+    &::after {
         @include shadow-low();
 
         background: $color-table-row;
@@ -57,7 +57,7 @@
         z-index: -1;
     }
 
-    &:after {
+    &::after {
         background-color: darken($color-table-row, 5%);
         transform: rotate(-3deg);
         z-index: -2;

src/scss/_settings.scss

@@ -130,7 +130,7 @@
         background: $white;
         display: block;
         // To override default opacity settings
-        filter: alpha(opacity=100);
+        filter: alpha(opacity = 100);
         opacity: 1;
 
         .actions {

test/api/Mocks.php

@@ -31,7 +31,7 @@ class DataMock {
         return $jwt;
     }
 
-    public static function CreateStandardUser($username = 'standard') {
+    public static function CreateStandardUser() {
         $user = R::dispense('user');
         self::setUserDefaults($user);
         R::store($user);

test/api/controllers/InvalidTest.php

@@ -8,7 +8,7 @@ class InvalidTest extends PHPUnit_Framework_TestCase {
 
         $data = new stdClass();
         $data->status = 'One of "success" or "failure".';
-        $data->data = 'An array of data (JSON objects and/or arrays).' .
+        $data->data = 'An array of data (JSON objects and/or arrays). ' .
             'The first object is a new JWT for the next request.';
         $data->alerts = 'An array of alerts, with "type" of "success", ' .
             '"error", "warn", or "info" and a "text" message.';