rei-mirrors
/
synapse
mirror of https://github.com/matrix-org/synapse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix presence bug introduced in 1.64 by #13313 (#14243) 

* Fix presence bug introduced in 1.64 by #13313

Signed-off-by: Mathieu Velten <mathieuv@matrix.org>

* Add changelog

* Add DISTINCT

* Apply suggestions from code review

Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
This commit is contained in:
Mathieu Velten 2022-10-27 14:16:00 +02:00 committed by GitHub
parent cbe01ccc3f
commit 4dc05f3019
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/14243.bugfix Normal file
View File

@ -0,0 +1 @@
Fix a bug introduced in Synapse 1.64.0 where presence updates could be missing from `/sync` responses.

3
synapse/storage/databases/main/roommember.py
View File

@ -742,7 +742,7 @@ class RoomMemberWorkerStore(EventsWorkerStore):
# user and the set of other users, and then checking if there is any # user and the set of other users, and then checking if there is any
# overlap. # overlap.
sql = f""" sql = f"""
SELECT b.state_key SELECT DISTINCT b.state_key
FROM ( FROM (
SELECT room_id FROM current_state_events SELECT room_id FROM current_state_events
WHERE type = 'm.room.member' AND membership = 'join' AND state_key = ? WHERE type = 'm.room.member' AND membership = 'join' AND state_key = ?
@ -751,7 +751,6 @@ class RoomMemberWorkerStore(EventsWorkerStore):
SELECT room_id, state_key FROM current_state_events SELECT room_id, state_key FROM current_state_events
WHERE type = 'm.room.member' AND membership = 'join' AND {clause} WHERE type = 'm.room.member' AND membership = 'join' AND {clause}
) AS b using (room_id) ) AS b using (room_id)
LIMIT 1
""" """
txn.execute(sql, (user_id, *args)) txn.execute(sql, (user_id, *args))