rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-02-02 22:45:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #796 from mathuo/795-popout-groups-bug

Browse Source 
bug: only dispose of ref group if empty
This commit is contained in:
mathuo 2024-12-20 20:05:02 +00:00 committed by GitHub
commit ff0bf75632
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 46 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
packages/dockview-core/src/__tests__/dockview/dockviewComponent.spec.ts
View File

@ -4867,6 +4867,51 @@ describe('dockviewComponent', () => {
);
});
test('move popout group of 1 panel inside grid', async () => {
const container = document.createElement('div');
window.open = () => setupMockWindow();
const dockview = new DockviewComponent(container, {
createComponent(options) {
switch (options.name) {
case 'default':
return new PanelContentPartTest(
options.id,
options.name
);
default:
throw new Error(`unsupported`);
}
},
});
dockview.layout(1000, 500);
const panel1 = dockview.addPanel({
id: 'panel_1',
component: 'default',
});
const panel2 = dockview.addPanel({
id: 'panel_2',
component: 'default',
});
const panel3 = dockview.addPanel({
id: 'panel_3',
component: 'default',
position: { direction: 'right' },
});
await dockview.addPopoutGroup(panel2);
panel2.api.moveTo({ position: 'top', group: panel3.group });
expect(dockview.panels.length).toBe(3);
expect(dockview.groups.length).toBe(3);
});
test('add a popout group', async () => {
const container = document.createElement('div');

2
packages/dockview-core/src/dockview/dockviewComponent.ts
View File

@ -1885,7 +1885,7 @@ export class DockviewComponent
const refGroup = selectedGroup.referenceGroup
? this.getPanel(selectedGroup.referenceGroup)
: undefined;
if (refGroup) {
if (refGroup && refGroup.panels.length === 0) {
this.removeGroup(refGroup);
}
}