diff --git a/packages/dockview/src/dnd/abstractDragHandler.ts b/packages/dockview/src/dnd/abstractDragHandler.ts index c4e595607..e16a1cc46 100644 --- a/packages/dockview/src/dnd/abstractDragHandler.ts +++ b/packages/dockview/src/dnd/abstractDragHandler.ts @@ -43,7 +43,7 @@ export abstract class DragHandler extends CompositeDisposable { event.dataTransfer.effectAllowed = 'move'; } }), - addDisposableListener(this.el, 'dragend', (ev) => { + addDisposableListener(this.el, 'dragend', () => { for (const iframe of this.iframes) { iframe.style.pointerEvents = 'auto'; } diff --git a/packages/dockview/src/dnd/droptarget.ts b/packages/dockview/src/dnd/droptarget.ts index 68cb0b515..a136c978f 100644 --- a/packages/dockview/src/dnd/droptarget.ts +++ b/packages/dockview/src/dnd/droptarget.ts @@ -60,7 +60,7 @@ export class Droptarget extends CompositeDisposable { this.addDisposables( this._onDrop, new DragAndDropObserver(this.element, { - onDragEnter: (e) => undefined, + onDragEnter: () => undefined, onDragOver: (e) => { if (isBooleanValue(this.options.canDisplayOverlay)) { if (!this.options.canDisplayOverlay) { @@ -115,10 +115,10 @@ export class Droptarget extends CompositeDisposable { this.setState(quadrant); }, - onDragLeave: (e) => { + onDragLeave: () => { this.removeDropTarget(); }, - onDragEnd: (e) => { + onDragEnd: () => { this.removeDropTarget(); }, onDrop: (e) => { diff --git a/packages/dockview/src/dockview/components/tab/defaultTab.ts b/packages/dockview/src/dockview/components/tab/defaultTab.ts index d349ed8a2..162c7946a 100644 --- a/packages/dockview/src/dockview/components/tab/defaultTab.ts +++ b/packages/dockview/src/dockview/components/tab/defaultTab.ts @@ -154,7 +154,7 @@ export class DefaultTab extends CompositeDisposable implements ITabRenderer { this.render(); } - public layout(width: number, height: number) { + public layout(_width: number, _height: number) { // noop } diff --git a/packages/dockview/src/dockview/components/watermark/watermark.ts b/packages/dockview/src/dockview/components/watermark/watermark.ts index 30f0f3015..3657938c2 100644 --- a/packages/dockview/src/dockview/components/watermark/watermark.ts +++ b/packages/dockview/src/dockview/components/watermark/watermark.ts @@ -11,7 +11,8 @@ import { PanelUpdateEvent } from '../../../panel/types'; export class Watermark extends CompositeDisposable - implements IWatermarkRenderer { + implements IWatermarkRenderer +{ private _element: HTMLElement; private group: GroupviewPanel | undefined; private params: GroupPanelPartInitParameters | undefined; @@ -56,7 +57,7 @@ export class Watermark ); } - update(event: PanelUpdateEvent) { + update(_event: PanelUpdateEvent) { // noop } @@ -68,7 +69,7 @@ export class Watermark return {}; } - layout(width: number, height: number) { + layout(_width: number, _height: number) { // noop } @@ -76,7 +77,7 @@ export class Watermark this.params = params; this.addDisposables( - this.params.containerApi.onDidLayoutChange((event) => { + this.params.containerApi.onDidLayoutChange(() => { this.render(); }) ); @@ -84,7 +85,7 @@ export class Watermark this.render(); } - updateParentGroup(group: GroupviewPanel, visible: boolean): void { + updateParentGroup(group: GroupviewPanel, _visible: boolean): void { this.group = group; this.render(); } diff --git a/packages/dockview/src/gridview/branchNode.ts b/packages/dockview/src/gridview/branchNode.ts index d8c26bc0f..0126fab48 100644 --- a/packages/dockview/src/gridview/branchNode.ts +++ b/packages/dockview/src/gridview/branchNode.ts @@ -282,7 +282,7 @@ export class BranchNode extends CompositeDisposable implements IView { this._childrenDisposable = Event.any( ...this.children.map((c) => c.onDidChange) - )((e) => { + )(() => { /** * indicate a change has occured to allows any re-rendering but don't bubble * event because that was specific to this branch diff --git a/packages/dockview/src/gridview/gridview.ts b/packages/dockview/src/gridview/gridview.ts index 1d67a183c..cbbb504a7 100644 --- a/packages/dockview/src/gridview/gridview.ts +++ b/packages/dockview/src/gridview/gridview.ts @@ -644,7 +644,7 @@ export class Gridview implements IDisposable { const isSiblingVisible = parent.isChildVisible(0); parent.removeChild(0, sizing); - const sizes = grandParent.children.map((size, i) => + const sizes = grandParent.children.map((_size, i) => grandParent.getChildSize(i) ); grandParent.removeChild(parentIndex, sizing); diff --git a/packages/dockview/src/gridview/gridviewComponent.ts b/packages/dockview/src/gridview/gridviewComponent.ts index 6fdb9341b..2ae69ea1c 100644 --- a/packages/dockview/src/gridview/gridviewComponent.ts +++ b/packages/dockview/src/gridview/gridviewComponent.ts @@ -169,7 +169,7 @@ export class GridviewComponent } setActive(panel: GridviewPanel): void { - this._groups.forEach((value, key) => { + this._groups.forEach((value, _key) => { value.value.setActive(panel === value.value); }); } diff --git a/packages/dockview/src/groupview/groupview.ts b/packages/dockview/src/groupview/groupview.ts index b59e31fb8..81341ee38 100644 --- a/packages/dockview/src/groupview/groupview.ts +++ b/packages/dockview/src/groupview/groupview.ts @@ -342,11 +342,11 @@ export class Groupview extends CompositeDisposable implements IGroupview { return this.panels.includes(panel); } - init(params: PanelInitParameters) { + init(_params: PanelInitParameters) { //noop } - update(params: PanelUpdateEvent) { + update(_params: PanelUpdateEvent) { //noop } diff --git a/packages/dockview/src/groupview/panel/content.ts b/packages/dockview/src/groupview/panel/content.ts index 21dd13248..d8b86a651 100644 --- a/packages/dockview/src/groupview/panel/content.ts +++ b/packages/dockview/src/groupview/panel/content.ts @@ -102,7 +102,7 @@ export class ContentContainer this.disposable.value = disposable; } - public layout(width: number, height: number): void { + public layout(_width: number, _height: number): void { // noop } diff --git a/packages/dockview/src/hostedContainer.ts b/packages/dockview/src/hostedContainer.ts index e1f377993..774b12d34 100644 --- a/packages/dockview/src/hostedContainer.ts +++ b/packages/dockview/src/hostedContainer.ts @@ -42,10 +42,10 @@ export class HostedContainer implements IDisposable { * When dragging somebody */ - window.addEventListener('dragstart', (ev) => { + window.addEventListener('dragstart', () => { this.element.style.pointerEvents = 'none'; }); - window.addEventListener('dragend', (ev) => { + window.addEventListener('dragend', () => { this.element.style.pointerEvents = ''; }); window.addEventListener('mousemove', (ev) => { @@ -73,7 +73,8 @@ export class HostedContainer implements IDisposable { return; } const frameRect = element.getBoundingClientRect(); - const containerRect = this.element.parentElement.getBoundingClientRect(); + const containerRect = + this.element.parentElement.getBoundingClientRect(); this.element.style.position = 'absolute'; this.element.style.top = `${frameRect.top - containerRect.top}px`; this.element.style.left = `${frameRect.left - containerRect.left}px`; diff --git a/packages/dockview/src/paneview/defaultPaneviewHeader.ts b/packages/dockview/src/paneview/defaultPaneviewHeader.ts index 7ea555835..5d4bd6e69 100644 --- a/packages/dockview/src/paneview/defaultPaneviewHeader.ts +++ b/packages/dockview/src/paneview/defaultPaneviewHeader.ts @@ -47,7 +47,7 @@ export class DefaultHeader }); } - update(params: PanelUpdateEvent) { + update(_params: PanelUpdateEvent) { // } diff --git a/packages/dockview/src/paneview/draggablePaneviewPanel.ts b/packages/dockview/src/paneview/draggablePaneviewPanel.ts index ebcad0d78..7cc0b6626 100644 --- a/packages/dockview/src/paneview/draggablePaneviewPanel.ts +++ b/packages/dockview/src/paneview/draggablePaneviewPanel.ts @@ -68,7 +68,7 @@ export abstract class DraggablePaneviewPanel extends PaneviewPanel { this.target = new Droptarget(this.element, { validOverlays: 'vertical', - canDisplayOverlay: (event: DragEvent) => { + canDisplayOverlay: () => { const data = getPaneData(); if (!data) { diff --git a/packages/dockview/src/paneview/paneview.ts b/packages/dockview/src/paneview/paneview.ts index 3ca79a582..6f9bf4631 100644 --- a/packages/dockview/src/paneview/paneview.ts +++ b/packages/dockview/src/paneview/paneview.ts @@ -73,7 +73,7 @@ export class Paneview extends CompositeDisposable implements IDisposable { // if we've added views from the descriptor we need to // add the panes to our Pane array and setup animation - this.getPanes().forEach((pane, index) => { + this.getPanes().forEach((pane) => { const disposable = new CompositeDisposable( pane.onDidChangeExpansionState(() => { this.setupAnimation(); diff --git a/packages/dockview/src/react/dockview/dockview.tsx b/packages/dockview/src/react/dockview/dockview.tsx index f3329e6b9..4bbca69f2 100644 --- a/packages/dockview/src/react/dockview/dockview.tsx +++ b/packages/dockview/src/react/dockview/dockview.tsx @@ -79,7 +79,7 @@ export const DockviewReact = React.forwardRef( const factory: GroupPanelFrameworkComponentFactory = { content: { createComponent: ( - id: string, + _id: string, componentId: string, component: React.FunctionComponent ): IContentRenderer => { @@ -94,7 +94,7 @@ export const DockviewReact = React.forwardRef( }, tab: { createComponent: ( - id: string, + _id: string, componentId: string, component: React.FunctionComponent ): ITabRenderer => { @@ -109,7 +109,7 @@ export const DockviewReact = React.forwardRef( }, watermark: { createComponent: ( - id: string, + _id: string, componentId: string, component: React.FunctionComponent<{}> ) => { diff --git a/packages/dockview/src/react/dockview/reactContentPart.ts b/packages/dockview/src/react/dockview/reactContentPart.ts index 093b276f5..d5c997085 100644 --- a/packages/dockview/src/react/dockview/reactContentPart.ts +++ b/packages/dockview/src/react/dockview/reactContentPart.ts @@ -32,8 +32,6 @@ export class ReactPanelContentPart implements IContentRenderer { private actionsPart?: ReactPart; private _group: GroupviewPanel | undefined; - // private hostedContainer: HostedContainer; - private readonly _onDidFocus = new Emitter(); readonly onDidFocus: Event = this._onDidFocus.event; @@ -56,13 +54,6 @@ export class ReactPanelContentPart implements IContentRenderer { this._element = document.createElement('div'); this._element.className = 'dockview-react-part'; - // this.hostedContainer = new HostedContainer({ - // id, - // }); - - // this.hostedContainer.onDidFocus(() => this._onDidFocus.fire()); - // this.hostedContainer.onDidBlur(() => this._onDidBlur.fire()); - this._actionsElement = document.createElement('div'); this._actionsElement.className = 'dockview-react-part'; } @@ -104,17 +95,13 @@ export class ReactPanelContentPart implements IContentRenderer { public updateParentGroup( group: GroupviewPanel, - isPanelVisible: boolean + _isPanelVisible: boolean ): void { this._group = group; } - public layout(width: number, height: number): void { + public layout(_width: number, _height: number): void { // noop - // this.hostedContainer.layout( - // this.element - // // { width, height } - // ); } public close(): Promise { @@ -125,7 +112,6 @@ export class ReactPanelContentPart implements IContentRenderer { this._onDidFocus.dispose(); this._onDidBlur.dispose(); this.part?.dispose(); - // this.hostedContainer?.dispose(); this.actionsPart?.dispose(); } } diff --git a/packages/dockview/src/react/dockview/reactWatermarkPart.ts b/packages/dockview/src/react/dockview/reactWatermarkPart.ts index da4240ab9..e858d3ae1 100644 --- a/packages/dockview/src/react/dockview/reactWatermarkPart.ts +++ b/packages/dockview/src/react/dockview/reactWatermarkPart.ts @@ -73,11 +73,11 @@ export class ReactWatermarkPart implements IWatermarkRenderer { }; } - layout(width: number, height: number) { + layout(_width: number, _height: number) { // noop - retrieval from api } - updateParentGroup(group: GroupviewPanel, isPanelVisible: boolean): void { + updateParentGroup(group: GroupviewPanel, _isPanelVisible: boolean): void { // noop - retrieval from api this._groupRef.value = group; } diff --git a/packages/dockview/src/react/dockview/v2/reactContentRenderer.ts b/packages/dockview/src/react/dockview/v2/reactContentRenderer.ts index 7196063dc..1a4872d23 100644 --- a/packages/dockview/src/react/dockview/v2/reactContentRenderer.ts +++ b/packages/dockview/src/react/dockview/v2/reactContentRenderer.ts @@ -90,12 +90,12 @@ export class ReactContentRenderer implements IContentRenderer { public updateParentGroup( group: GroupviewPanel, - isPanelVisible: boolean + _isPanelVisible: boolean ): void { this._group = group; } - public layout(width: number, height: number): void { + public layout(_width: number, _height: number): void { this._hostedContainer.layout(this.element); } diff --git a/packages/dockview/src/react/dockview/v2/webviewContentRenderer.ts b/packages/dockview/src/react/dockview/v2/webviewContentRenderer.ts index 12033a2db..8cdef1604 100644 --- a/packages/dockview/src/react/dockview/v2/webviewContentRenderer.ts +++ b/packages/dockview/src/react/dockview/v2/webviewContentRenderer.ts @@ -43,13 +43,13 @@ export class WebviewContentRenderer implements IContentRenderer { } public updateParentGroup( - group: GroupviewPanel, - isPanelVisible: boolean + _group: GroupviewPanel, + _isPanelVisible: boolean ): void { // } - public layout(width: number, height: number): void { + public layout(_width: number, _height: number): void { this._hostedContainer.layout(this._element); } diff --git a/packages/dockview/src/react/paneview/paneview.tsx b/packages/dockview/src/react/paneview/paneview.tsx index 80dcdcd44..33d8e7410 100644 --- a/packages/dockview/src/react/paneview/paneview.tsx +++ b/packages/dockview/src/react/paneview/paneview.tsx @@ -64,7 +64,7 @@ export const PaneviewReact = React.forwardRef( React.useEffect(() => { const createComponent = ( id: string, - componentId: string, + _componentId: string, component: any ) => new PanePanelSection(id, component, {