rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-09-14 13:17:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #887 from mathuo/884-cant-drop-tabs-between-panels-and-some-other-issues-with-v4-1

Browse Source 
bug: dnd issues
This commit is contained in:
mathuo 2025-03-18 19:40:21 +00:00 committed by GitHub
commit f545a0a5c7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 54 additions and 58 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/dockview-core/src/dockview/components/titlebar/tabsContainer.ts
View File

@ -152,6 +152,8 @@ export class TabsContainer
this._element.appendChild(this.rightActionsContainer); this._element.appendChild(this.rightActionsContainer);
this.addDisposables( this.addDisposables(
this.tabs.onDrop((e) => this._onDrop.fire(e)),
this.tabs.onWillShowOverlay((e) => this._onWillShowOverlay.fire(e)),
accessor.onDidOptionsChange(() => { accessor.onDidOptionsChange(() => {
this.tabs.showTabsOverflowControl = this.tabs.showTabsOverflowControl =
!accessor.options.disableTabsOverflowList; !accessor.options.disableTabsOverflowList;

14
packages/dockview-core/src/dockview/dockviewComponent.scss
View File

@ -18,10 +18,8 @@
.dv-groupview { .dv-groupview {
&.dv-active-group { &.dv-active-group {
> .dv-tabs-and-actions-container > .dv-tabs-and-actions-container {
> .dv-scrollable .dv-tabs-container > .dv-tab {
> .dv-tabs-container
> .dv-tab {
&.dv-active-tab { &.dv-active-tab {
background-color: var( background-color: var(
--dv-activegroup-visiblepanel-tab-background-color --dv-activegroup-visiblepanel-tab-background-color
@ -36,11 +34,10 @@
} }
} }
} }
}
&.dv-inactive-group { &.dv-inactive-group {
> .dv-tabs-and-actions-container > .dv-tabs-and-actions-container {
> .dv-scrollable .dv-tabs-container > .dv-tab {
> .dv-tabs-container
> .dv-tab {
&.dv-active-tab { &.dv-active-tab {
background-color: var( background-color: var(
--dv-inactivegroup-visiblepanel-tab-background-color --dv-inactivegroup-visiblepanel-tab-background-color
@ -56,6 +53,7 @@
} }
} }
} }
}
/** /**
* when a tab is dragged we lose the above stylings because they are conditional on parent elements * when a tab is dragged we lose the above stylings because they are conditional on parent elements

8
packages/dockview-core/src/theme.scss
View File

@ -216,8 +216,7 @@
.dv-groupview { .dv-groupview {
&.dv-active-group { &.dv-active-group {
> .dv-tabs-and-actions-container { > .dv-tabs-and-actions-container {
> .dv-scrollable { .dv-tabs-container {
> .dv-tabs-container {
> .dv-tab.dv-active-tab { > .dv-tab.dv-active-tab {
position: relative; position: relative;
@ -235,11 +234,9 @@
} }
} }
} }
}
&.dv-inactive-group { &.dv-inactive-group {
> .dv-tabs-and-actions-container { > .dv-tabs-and-actions-container {
> .dv-scrollable { .dv-tabs-container {
> .dv-tabs-container {
> .dv-tab.dv-active-tab { > .dv-tab.dv-active-tab {
position: relative; position: relative;
@ -259,7 +256,6 @@
} }
} }
} }
}
.dockview-theme-abyss { .dockview-theme-abyss {
@include dockview-theme-abyss-mixin(); @include dockview-theme-abyss-mixin();