From e55355695e2767eae66b9a48c7306bb01d6142fa Mon Sep 17 00:00:00 2001 From: Matthew O'Connor Date: Sat, 14 Nov 2020 10:21:57 +0000 Subject: [PATCH] disallow duplicate splitivew panels (identical ids) --- packages/splitview/src/splitview/componentSplitview.ts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/splitview/src/splitview/componentSplitview.ts b/packages/splitview/src/splitview/componentSplitview.ts index 3e0bc2429..517de9208 100644 --- a/packages/splitview/src/splitview/componentSplitview.ts +++ b/packages/splitview/src/splitview/componentSplitview.ts @@ -161,6 +161,10 @@ export class ComponentSplitview } addPanel(options: AddSplitviewComponentOptions): void { + if (this.panels.has(options.id)) { + throw new Error(`panel ${options.id} already exists`); + } + const view = createComponent( options.id, options.component, @@ -259,6 +263,10 @@ export class ComponentSplitview views: views.map((view) => { const data = view.data; + if (this.panels.has(data.id)) { + throw new Error(`panel ${data.id} already exists`); + } + const panel = createComponent( data.id, data.component,