From e9bf894acb86484a63b3f1053cfb32e6ba6e73a6 Mon Sep 17 00:00:00 2001
From: mathuo <6710312+mathuo@users.noreply.github.com>
Date: Wed, 13 Jul 2022 21:30:17 +0100
Subject: [PATCH] fix: change get(params)

---
 .../dockview/dockviewGroupPanel.spec.ts       | 22 +++++++++++++++++++
 .../__tests__/gridview/gridviewPanel.spec.ts  | 20 +++++++++++++++++
 .../src/dockview/dockviewGroupPanel.ts        |  2 +-
 3 files changed, 43 insertions(+), 1 deletion(-)
 create mode 100644 packages/dockview/src/__tests__/gridview/gridviewPanel.spec.ts

diff --git a/packages/dockview/src/__tests__/dockview/dockviewGroupPanel.spec.ts b/packages/dockview/src/__tests__/dockview/dockviewGroupPanel.spec.ts
index 3aeb62856..dd5489046 100644
--- a/packages/dockview/src/__tests__/dockview/dockviewGroupPanel.spec.ts
+++ b/packages/dockview/src/__tests__/dockview/dockviewGroupPanel.spec.ts
@@ -112,4 +112,26 @@ describe('dockviewGroupPanel', () => {
 
         expect(view.dispose).toHaveBeenCalled();
     });
+
+    test('get params', () => {
+        const dockviewApiMock = jest.fn<DockviewApi, []>(() => {
+            return {} as any;
+        });
+        const accessorMock = jest.fn<DockviewComponent, []>(() => {
+            return {} as any;
+        });
+        const groupMock = jest.fn<GroupPanel, []>(() => {
+            return {} as any;
+        });
+        const api = new dockviewApiMock();
+        const accessor = new accessorMock();
+        const group = new groupMock();
+        const cut = new DockviewGroupPanel('fake-id', accessor, api, group);
+
+        expect(cut.params).toEqual(undefined);
+
+        cut.update({ params: { params: { variableA: 'A', variableB: 'B' } } });
+
+        expect(cut.params).toEqual({ variableA: 'A', variableB: 'B' });
+    });
 });
diff --git a/packages/dockview/src/__tests__/gridview/gridviewPanel.spec.ts b/packages/dockview/src/__tests__/gridview/gridviewPanel.spec.ts
new file mode 100644
index 000000000..7a26487a0
--- /dev/null
+++ b/packages/dockview/src/__tests__/gridview/gridviewPanel.spec.ts
@@ -0,0 +1,20 @@
+import { DockviewComponent } from '../../dockview/dockviewComponent';
+import { GroupPanel } from '../../groupview/groupviewPanel';
+
+describe('gridviewPanel', () => {
+    test('get panel', () => {
+        const accessorMock = jest.fn<DockviewComponent, []>(() => {
+            return {} as any;
+        });
+
+        const accessor = new accessorMock();
+
+        const cut = new GroupPanel(accessor, 'id', {});
+
+        expect(cut.params).toEqual(undefined);
+
+        cut.update({ params: { variableA: 'A', variableB: 'B' } });
+
+        expect(cut.params).toEqual({ variableA: 'A', variableB: 'B' });
+    });
+});
diff --git a/packages/dockview/src/dockview/dockviewGroupPanel.ts b/packages/dockview/src/dockview/dockviewGroupPanel.ts
index 775ec8864..e52ea2921 100644
--- a/packages/dockview/src/dockview/dockviewGroupPanel.ts
+++ b/packages/dockview/src/dockview/dockviewGroupPanel.ts
@@ -28,7 +28,7 @@ export class DockviewGroupPanel
     private _suppressClosable: boolean;
 
     get params() {
-        return this._params?.params;
+        return this._params;
     }
 
     get title() {