rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-09-29 04:27:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: popout window unique id

Browse Source
This commit is contained in:
mathuo 2024-01-10 20:00:50 +00:00
parent 312aeded25
commit dbe0fe88ad
No known key found for this signature in database
GPG Key ID: C6EEDEFD6CA07281
2 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
packages/dockview-core/src/dockview/dockviewComponent.ts
View File

@ -539,16 +539,20 @@ export class DockviewComponent
const theme = getTheme(this.gridview.element); const theme = getTheme(this.gridview.element);
const popoutWindow = new DockviewPopoutGroupPanel(group, { const popoutWindow = new DockviewPopoutGroupPanel(
className: theme ?? '', `${this.id}-${group.id}`, // globally unique within dockview
popoutUrl: options?.popoutUrl ?? '/popout.html', group,
box: { {
left: window.screenX + box.left, className: theme ?? '',
top: window.screenY + box.top, popoutUrl: options?.popoutUrl ?? '/popout.html',
width: box.width, box: {
height: box.height, left: window.screenX + box.left,
}, top: window.screenY + box.top,
}); width: box.width,
height: box.height,
},
}
);
popoutWindow.addDisposables( popoutWindow.addDisposables(
{ {

3
packages/dockview-core/src/dockview/dockviewPopoutGroupPanel.ts
View File

@ -7,6 +7,7 @@ export class DockviewPopoutGroupPanel extends CompositeDisposable {
readonly window: PopoutWindow; readonly window: PopoutWindow;
constructor( constructor(
readonly id: string,
readonly group: DockviewGroupPanel, readonly group: DockviewGroupPanel,
private readonly options: { private readonly options: {
className: string; className: string;
@ -16,7 +17,7 @@ export class DockviewPopoutGroupPanel extends CompositeDisposable {
) { ) {
super(); super();
this.window = new PopoutWindow('test', options.className ?? '', { this.window = new PopoutWindow(id, options.className ?? '', {
url: this.options.popoutUrl, url: this.options.popoutUrl,
left: this.options.box.left, left: this.options.box.left,
top: this.options.box.top, top: this.options.box.top,