From d8ae04e274ac1b8e86dd23c17610c42477302613 Mon Sep 17 00:00:00 2001
From: mathuo <6710312+mathuo@users.noreply.github.com>
Date: Sun, 3 Nov 2024 19:14:49 +0000
Subject: [PATCH] chore: sonar

---
 packages/dockview-core/src/dockview/dockviewComponent.ts | 3 ---
 packages/dockview-core/src/dockview/types.ts             | 2 +-
 packages/dockview-core/src/splitview/splitview.ts        | 2 +-
 3 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/packages/dockview-core/src/dockview/dockviewComponent.ts b/packages/dockview-core/src/dockview/dockviewComponent.ts
index f56c627a7..27e95fc52 100644
--- a/packages/dockview-core/src/dockview/dockviewComponent.ts
+++ b/packages/dockview-core/src/dockview/dockviewComponent.ts
@@ -592,12 +592,9 @@ export class DockviewComponent
             }
         );
 
-        let windowExplicitlyClosed = false;
-
         const popoutWindowDisposable = new CompositeDisposable(
             _window,
             _window.onDidClose(() => {
-                windowExplicitlyClosed = true;
                 popoutWindowDisposable.dispose();
             })
         );
diff --git a/packages/dockview-core/src/dockview/types.ts b/packages/dockview-core/src/dockview/types.ts
index aa5cae998..3b2c8f112 100644
--- a/packages/dockview-core/src/dockview/types.ts
+++ b/packages/dockview-core/src/dockview/types.ts
@@ -2,7 +2,7 @@ import { DockviewPanelApi } from '../api/dockviewPanelApi';
 import { PanelInitParameters, IPanel } from '../panel/types';
 import { DockviewApi } from '../api/component.api';
 import { Optional } from '../types';
-import { DockviewGroupPanel, IDockviewGroupPanel } from './dockviewGroupPanel';
+import { IDockviewGroupPanel } from './dockviewGroupPanel';
 import { DockviewPanelRenderer } from '../overlay/overlayRenderContainer';
 
 export interface HeaderPartInitParameters {
diff --git a/packages/dockview-core/src/splitview/splitview.ts b/packages/dockview-core/src/splitview/splitview.ts
index 2d774c6ad..c4ceeb3d0 100644
--- a/packages/dockview-core/src/splitview/splitview.ts
+++ b/packages/dockview-core/src/splitview/splitview.ts
@@ -101,7 +101,7 @@ export class Splitview {
     private readonly viewContainer: HTMLElement;
     private readonly sashContainer: HTMLElement;
     private readonly viewItems: ViewItem[] = [];
-    private sashes: ISashItem[] = [];
+    private readonly sashes: ISashItem[] = [];
     private _orientation: Orientation;
     private _size = 0;
     private _orthogonalSize = 0;