From 6511b8d9362e0c56b4384eafe3fb5e2417b8cdff Mon Sep 17 00:00:00 2001 From: Hieu Date: Mon, 24 Feb 2025 03:03:00 +0700 Subject: [PATCH] Make addGroup wiithout reference panel/group allow id option --- .../src/dockview/dockviewComponent.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/dockview-core/src/dockview/dockviewComponent.ts b/packages/dockview-core/src/dockview/dockviewComponent.ts index 20343ae6c..9c8484df7 100644 --- a/packages/dockview-core/src/dockview/dockviewComponent.ts +++ b/packages/dockview-core/src/dockview/dockviewComponent.ts @@ -1100,7 +1100,7 @@ export class DockviewComponent this.updateWatermark(); } - private orthogonalize(position: Position): DockviewGroupPanel { + private orthogonalize(position: Position, options?: GroupOptions): DockviewGroupPanel { switch (position) { case 'top': case 'bottom': @@ -1126,10 +1126,10 @@ export class DockviewComponent case 'top': case 'left': case 'center': - return this.createGroupAtLocation([0]); // insert into first position + return this.createGroupAtLocation([0], undefined, options); // insert into first position case 'bottom': case 'right': - return this.createGroupAtLocation([this.gridview.length]); // insert into last position + return this.createGroupAtLocation([this.gridview.length], undefined, options); // insert into last position default: throw new Error(`unsupported position ${position}`); } @@ -1808,7 +1808,8 @@ export class DockviewComponent } } else { const group = this.orthogonalize( - directionToPosition(options.direction) + directionToPosition(options.direction), + options ); if (!options.skipSetActive) { this.doSetGroupAndPanelActive(group); @@ -2474,9 +2475,10 @@ export class DockviewComponent private createGroupAtLocation( location: number[], - size?: number + size?: number, + options?: GroupOptions ): DockviewGroupPanel { - const group = this.createGroup(); + const group = this.createGroup(options); this.doAddGroup(group, location, size); return group; }