rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-02-02 14:35:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: sonarcloud requests

Browse Source
This commit is contained in:
mathuo 2024-05-13 20:50:05 +01:00
parent 35630e4f1c
commit c4ab6ac562
No known key found for this signature in database
GPG Key ID: C6EEDEFD6CA07281
5 changed files with 32 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/dockview-core/src/api/dockviewPanelApi.ts
View File

@ -204,13 +204,14 @@ export class DockviewPanelApiImpl
this.groupEventsDisposable.value = new CompositeDisposable(
this.group.api.onDidVisibilityChange((event) => {
if (!event.isVisible && this.isVisible) {
this._onDidVisibilityChange.fire(event);
} else if (
event.isVisible &&
!this.isVisible &&
this.group.model.isPanelActive(this.panel)
) {
const hasBecomeHidden = !event.isVisible && this.isVisible;
const hasBecomeVisible = event.isVisible && !this.isVisible;
const isActivePanel = this.group.model.isPanelActive(
this.panel
);
if (hasBecomeHidden || (hasBecomeVisible && isActivePanel)) {
this._onDidVisibilityChange.fire(event);
}
}),

6
packages/dockview-core/src/dnd/dataTransfer.ts
View File

@ -1,4 +1,8 @@
class TransferObject {}
class TransferObject {
constructor() {
// intentionally empty class
}
}
export class PanelTransfer extends TransferObject {
constructor(

25
packages/dockview-core/src/dockview/dockviewComponent.ts
View File

@ -652,7 +652,7 @@ export class DockviewComponent
const box: Box = getBox();
const groupId =
options?.overridePopoutGroup?.id ?? this.getNextGroupId(); //item.id;
options?.overridePopoutGroup?.id ?? this.getNextGroupId();
if (itemToPopout.api.location.type === 'grid') {
itemToPopout.api.setVisible(false);
@ -811,17 +811,15 @@ export class DockviewComponent
skipPopoutAssociated: true,
});
}
} else {
if (this.getPanel(group.id)) {
const removedGroup = this.doRemoveGroup(group, {
skipDispose: true,
skipActive: true,
});
removedGroup.model.renderContainer =
this.overlayRenderContainer;
removedGroup.model.location = { type: 'grid' };
returnedGroup = removedGroup;
}
} else if (this.getPanel(group.id)) {
const removedGroup = this.doRemoveGroup(group, {
skipDispose: true,
skipActive: true,
});
removedGroup.model.renderContainer =
this.overlayRenderContainer;
removedGroup.model.location = { type: 'grid' };
returnedGroup = removedGroup;
}
})
);
@ -894,7 +892,7 @@ export class DockviewComponent
this.doRemoveGroup(item, {
skipDispose: true,
skipPopoutReturn: true,
skipPopoutAssociated: !!popoutReferenceGroup,
skipPopoutAssociated: false,
});
}
}
@ -1372,7 +1370,6 @@ export class DockviewComponent
const groups = Array.from(this._groups.values()).map((_) => _.value);
const hasActiveGroup = !!this.activeGroup;
const hasActivePanel = !!this.activePanel;
for (const group of groups) {
// remove the group will automatically remove the panels

2
packages/dockview-core/src/dockview/dockviewGroupPanelModel.ts
View File

@ -993,7 +993,7 @@ export class DockviewGroupPanelModel
target,
position,
getPanelData,
this.accessor.getPanel(this.id)!
this.accessor.getPanel(this.id)
);
this._onUnhandledDragOverEvent.fire(firedEvent);

17
packages/dockview/src/dockview/dockview.tsx
View File

@ -63,15 +63,12 @@ export interface IDockviewReactProps extends DockviewOptions {
}
function extractCoreOptions(props: IDockviewReactProps): DockviewOptions {
const coreOptions = (PROPERTY_KEYS as (keyof DockviewOptions)[]).reduce(
(obj, key) => {
if (key in props) {
obj[key] = props[key] as any;
}
return obj;
},
{} as Partial<DockviewComponentOptions>
);
const coreOptions = PROPERTY_KEYS.reduce((obj, key) => {
if (key in props) {
obj[key] = props[key] as any;
}
return obj;
}, {} as Partial<DockviewComponentOptions>);
return coreOptions as DockviewOptions;
}
@ -91,7 +88,7 @@ export const DockviewReact = React.forwardRef(
const changes: Partial<DockviewOptions> = {};
PROPERTY_KEYS.forEach((propKey) => {
const key = propKey as keyof DockviewOptions;
const key = propKey;
const propValue = props[key];
if (key in props && propValue !== prevProps.current[key]) {