rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-09-06 01:16:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #438 from mathuo/360-investigate-opening-tabs-in-new-browser-window

Browse Source 
feat: popout window unique id
This commit is contained in:
mathuo 2024-01-10 20:01:25 +00:00 committed by GitHub
commit b084ac6e00
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
packages/dockview-core/src/dockview/dockviewComponent.ts
View File

@ -539,16 +539,20 @@ export class DockviewComponent
const theme = getTheme(this.gridview.element);
const popoutWindow = new DockviewPopoutGroupPanel(group, {
className: theme ?? '',
popoutUrl: options?.popoutUrl ?? '/popout.html',
box: {
left: window.screenX + box.left,
top: window.screenY + box.top,
width: box.width,
height: box.height,
},
});
const popoutWindow = new DockviewPopoutGroupPanel(
`${this.id}-${group.id}`, // globally unique within dockview
group,
{
className: theme ?? '',
popoutUrl: options?.popoutUrl ?? '/popout.html',
box: {
left: window.screenX + box.left,
top: window.screenY + box.top,
width: box.width,
height: box.height,
},
}
);
popoutWindow.addDisposables(
{

3
packages/dockview-core/src/dockview/dockviewPopoutGroupPanel.ts
View File

@ -7,6 +7,7 @@ export class DockviewPopoutGroupPanel extends CompositeDisposable {
readonly window: PopoutWindow;
constructor(
readonly id: string,
readonly group: DockviewGroupPanel,
private readonly options: {
className: string;
@ -16,7 +17,7 @@ export class DockviewPopoutGroupPanel extends CompositeDisposable {
) {
super();
this.window = new PopoutWindow('test', options.className ?? '', {
this.window = new PopoutWindow(id, options.className ?? '', {
url: this.options.popoutUrl,
left: this.options.box.left,
top: this.options.box.top,