rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-03-12 00:42:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #346 from mathuo/344-floating-tab-groups-move-in-bested-dockview

Browse Source 
bug: skip resize for unmounted elements
This commit is contained in:
mathuo 2023-10-01 20:45:31 +01:00 committed by GitHub
commit a96400d970
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/dockview-core/src/resizable.ts
View File

@ -29,6 +29,16 @@ export abstract class Resizable extends CompositeDisposable {
*/ */
return; return;
} }
if (!document.body.contains(this._element)) {
/**
* since the event is dispatched through requestAnimationFrame there is a small chance
* the component is no longer attached to the DOM, if that is the case the dimensions
* are mostly likely all zero and meaningless. we should skip this case.
*/
return;
}
const { width, height } = entry.contentRect; const { width, height } = entry.contentRect;
this.layout(width, height); this.layout(width, height);
}) })