rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-01-23 09:55:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch '469-add-window-lifecycle-callbacks' of https://github.com/mathuo/dockview into 469-add-window-lifecycle-callbacks-1

Browse Source
This commit is contained in:
mathuo 2024-01-28 13:38:02 +00:00
commit a8472e8b71
No known key found for this signature in database
GPG Key ID: C6EEDEFD6CA07281
4 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/dockview-core/src/api/component.api.ts
View File

@ -830,6 +830,8 @@ export class DockviewApi implements CommonApi<SerializedDockview> {
options?: { options?: {
position?: Box; position?: Box;
popoutUrl?: string; popoutUrl?: string;
onOpened?: (id: string, window: Window) => void;
onClosing?: (id: string, window: Window) => void;
} }
): void { ): void {
this.component.addPopoutGroup(item, options); this.component.addPopoutGroup(item, options);

6
packages/dockview-core/src/dockview/dockviewComponent.ts
View File

@ -287,6 +287,8 @@ export interface IDockviewComponent extends IBaseGrid<DockviewGroupPanel> {
options?: { options?: {
position?: Box; position?: Box;
popoutUrl?: string; popoutUrl?: string;
onOpened?: (id: string, window: Window) => void;
onClosing?: (id: string, window: Window) => void;
} }
): void; ): void;
} }
@ -514,6 +516,8 @@ export class DockviewComponent
skipRemoveGroup?: boolean; skipRemoveGroup?: boolean;
position?: Box; position?: Box;
popoutUrl?: string; popoutUrl?: string;
onOpened?: (id: string, window: Window) => void;
onClosing?: (id: string, window: Window) => void;
} }
): void { ): void {
let group: DockviewGroupPanel; let group: DockviewGroupPanel;
@ -562,6 +566,8 @@ export class DockviewComponent
width: box.width, width: box.width,
height: box.height, height: box.height,
}, },
onOpened: options?.onOpened,
onClosing: options?.onClosing
} }
); );

4
packages/dockview-core/src/dockview/dockviewPopoutGroupPanel.ts
View File

@ -13,6 +13,8 @@ export class DockviewPopoutGroupPanel extends CompositeDisposable {
className: string; className: string;
popoutUrl: string; popoutUrl: string;
box: Box; box: Box;
onOpened?: (id: string, window: Window) => void;
onClosing?: (id: string, window: Window) => void;
} }
) { ) {
super(); super();
@ -23,6 +25,8 @@ export class DockviewPopoutGroupPanel extends CompositeDisposable {
top: this.options.box.top, top: this.options.box.top,
width: this.options.box.width, width: this.options.box.width,
height: this.options.box.height, height: this.options.box.height,
onOpened: this.options.onOpened,
onClosing: this.options.onClosing,
}); });
group.model.location = { group.model.location = {

10
packages/dockview-core/src/popoutWindow.ts
View File

@ -5,6 +5,8 @@ import { Box } from './types';
export type PopoutWindowOptions = { export type PopoutWindowOptions = {
url: string; url: string;
onOpened?: (id: string, window: Window) => void;
onClosing?: (id: string, window: Window) => void;
} & Box; } & Box;
export class PopoutWindow extends CompositeDisposable { export class PopoutWindow extends CompositeDisposable {
@ -51,6 +53,10 @@ export class PopoutWindow extends CompositeDisposable {
if (this._window) { if (this._window) {
this._onWillClose.fire(); this._onWillClose.fire();
if (this.options.onClosing) {
this.options.onClosing(this.target, this._window.value);
}
this._window.disposable.dispose(); this._window.disposable.dispose();
this._window.value.close(); this._window.value.close();
this._window = null; this._window = null;
@ -125,6 +131,10 @@ export class PopoutWindow extends CompositeDisposable {
this.close(); this.close();
}); });
}); });
if (this.options.onOpened) {
this.options.onOpened(this.target, externalWindow);
}
} }
private createPopoutWindowContainer(): HTMLElement { private createPopoutWindowContainer(): HTMLElement {