rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-02-09 01:45:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #731 from mathuo/710-reloading-of-popout-window-is-displaying-blank-page

Browse Source 
bug: close popout window if unloaded
This commit is contained in:
mathuo 2024-10-12 15:20:51 +01:00 committed by GitHub
commit a202a49182
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/dockview-core/src/popoutWindow.ts
View File

@ -1,6 +1,6 @@
import { addStyles } from './dom'; import { addStyles } from './dom';
import { Emitter, addDisposableWindowListener } from './events'; import { Emitter, addDisposableWindowListener } from './events';
import { CompositeDisposable, IDisposable } from './lifecycle'; import { CompositeDisposable, Disposable, IDisposable } from './lifecycle';
import { Box } from './types'; import { Box } from './types';
export type PopoutWindowOptions = { export type PopoutWindowOptions = {
@ -99,6 +99,9 @@ export class PopoutWindow extends CompositeDisposable {
this._window = { value: externalWindow, disposable }; this._window = { value: externalWindow, disposable };
disposable.addDisposables( disposable.addDisposables(
Disposable.from(() => {
externalWindow.close();
}),
addDisposableWindowListener(window, 'beforeunload', () => { addDisposableWindowListener(window, 'beforeunload', () => {
/** /**
* before the main window closes we should close this popup too * before the main window closes we should close this popup too