rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-05-07 12:08:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: extract custom react props into seperate prop variable

Browse Source
This commit is contained in:
mathuo 2021-06-03 21:21:32 +01:00
parent 2c02bed5d0
commit 9060ff1a55
12 changed files with 36 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
packages/dockview/src/react/dockview/dockview.tsx
View File

@ -11,28 +11,33 @@ import { DockviewPanelApi } from '../../api/groupPanelApi';
import { usePortalsLifecycle } from '../react';
import { DockviewApi } from '../../api/component.api';
import { ReactWatermarkPart } from './reactWatermarkPart';
import { PanelCollection } from '../types';
import { PanelCollection, PanelParameters } from '../types';
import { watchElementResize } from '../../dom';
import { IContentRenderer, ITabRenderer } from '../../groupview/types';
export interface IGroupPanelBaseProps {
api: DockviewPanelApi;
containerApi: DockviewApi;
[key: string]: any;
export interface PanelCollection1<T extends IDockviewPanelProps> {
[name: string]: React.FunctionComponent<T>;
}
export interface IDockviewPanelProps extends IGroupPanelBaseProps {
[key: string]: any;
export interface IGroupPanelBaseProps<T extends {} = Record<string, any>>
extends PanelParameters<T> {
api: DockviewPanelApi;
containerApi: DockviewApi;
}
export interface IDockviewPanelProps<T extends {} = Record<string, any>>
extends IGroupPanelBaseProps<T> {
// noop
}
export interface DockviewReadyEvent {
api: DockviewApi;
}
export interface IWatermarkPanelProps {
export interface IWatermarkPanelProps<T extends {} = Record<string, any>>
extends PanelParameters<T> {
containerApi: DockviewApi;
close(): void;
[key: string]: any;
}
export interface IDockviewReactProps {

2
packages/dockview/src/react/dockview/reactContentPart.ts
View File

@ -102,7 +102,7 @@ export class ReactPanelContentPart implements IContentRenderer {
this.reactPortalStore,
this.component,
{
...parameters.params,
params: parameters.params,
api: parameters.api,
containerApi: parameters.containerApi,
},

2
packages/dockview/src/react/dockview/reactHeaderPart.ts
View File

@ -37,7 +37,7 @@ export class ReactPanelHeaderPart implements ITabRenderer {
this.reactPortalStore,
this.component,
{
...parameters.params,
params: parameters.params,
api: parameters.api,
containerApi: parameters.containerApi,
}

2
packages/dockview/src/react/dockview/reactWatermarkPart.ts
View File

@ -38,7 +38,7 @@ export class ReactWatermarkPart implements WatermarkPart {
this.reactPortalStore,
this.component,
{
...parameters.params,
params: parameters.params,
api: parameters.api,
containerApi: parameters.containerApi,
close: () => {

3
packages/dockview/src/react/dockview/v2/reactContentRenderer.ts
View File

@ -67,10 +67,9 @@ export class ReactContentRenderer implements IContentRenderer {
this.reactPortalStore,
this.component,
{
...parameters.params,
params: parameters.params,
api: parameters.api,
containerApi: parameters.containerApi,
setActionsbar: () => null as any,
}
);
}

6
packages/dockview/src/react/gridview/gridview.tsx
View File

@ -8,17 +8,17 @@ import { Orientation } from '../../splitview/core/splitview';
import { ReactGridPanelView } from './view';
import { usePortalsLifecycle } from '../react';
import { GridviewApi } from '../../api/component.api';
import { PanelCollection } from '../types';
import { PanelCollection, PanelParameters } from '../types';
import { watchElementResize } from '../../dom';
export interface GridviewReadyEvent {
api: GridviewApi;
}
export interface IGridviewPanelProps {
export interface IGridviewPanelProps<T extends {} = Record<string, any>>
extends PanelParameters<T> {
api: GridviewPanelApi;
containerApi: GridviewApi;
[key: string]: any;
}
export interface IGridviewReactProps {

2
packages/dockview/src/react/gridview/view.ts
View File

@ -21,7 +21,7 @@ export class ReactGridPanelView extends GridviewPanel {
this.reactPortalStore,
this.reactComponent,
{
...(this.params?.params || {}),
params: this.params?.params || {},
api: this.api,
containerApi: (this.params as GridviewInitParameters)
.containerApi,

6
packages/dockview/src/react/paneview/paneview.tsx
View File

@ -7,18 +7,18 @@ import {
import { usePortalsLifecycle } from '../react';
import { PaneviewApi } from '../../api/component.api';
import { PanePanelSection } from './view';
import { PanelCollection } from '../types';
import { PanelCollection, PanelParameters } from '../types';
import { watchElementResize } from '../../dom';
export interface PaneviewReadyEvent {
api: PaneviewApi;
}
export interface IPaneviewPanelProps {
export interface IPaneviewPanelProps<T extends {} = Record<string, any>>
extends PanelParameters<T> {
api: PaneviewPanelApi;
containerApi: PaneviewApi;
title: string;
[key: string]: any;
}
export interface IPaneviewReactProps {

2
packages/dockview/src/react/paneview/view.tsx
View File

@ -31,7 +31,7 @@ export class PanePanelSection implements IPaneBodyPart {
this.reactPortalStore,
this.component,
{
...parameters.params,
params: parameters.params,
api: parameters.api,
title: parameters.title,
containerApi: parameters.containerApi,

6
packages/dockview/src/react/splitview/splitview.tsx
View File

@ -7,7 +7,7 @@ import {
} from '../../splitview/splitviewComponent';
import { Orientation } from '../../splitview/core/splitview';
import { usePortalsLifecycle } from '../react';
import { PanelCollection } from '../types';
import { PanelCollection, PanelParameters } from '../types';
import { ReactPanelView } from './view';
import { watchElementResize } from '../../dom';
@ -15,10 +15,10 @@ export interface SplitviewReadyEvent {
api: SplitviewApi;
}
export interface ISplitviewPanelProps {
export interface ISplitviewPanelProps<T extends {} = Record<string, any>>
extends PanelParameters<T> {
api: SplitviewPanelApi;
containerApi: SplitviewApi;
[key: string]: any;
}
export interface ISplitviewReactProps {

2
packages/dockview/src/react/splitview/view.ts
View File

@ -19,7 +19,7 @@ export class ReactPanelView extends SplitviewPanel {
this.reactPortalStore,
this.reactComponent,
{
...(this.params?.params || {}),
params: this.params?.params || {},
api: this.api,
containerApi: (this.params as PanelViewInitParameters)
.containerApi,

6
packages/dockview/src/react/types.ts
View File

@ -1,3 +1,9 @@
import * as React from 'react';
export interface PanelCollection<T extends object> {
[name: string]: React.FunctionComponent<T>;
}
export interface PanelParameters<T extends {} = Record<string, any>> {
params: T;
}