rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-09-11 19:58:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: adjust public method names

Browse Source
This commit is contained in:
mathuo 2025-06-13 22:56:29 +01:00
parent b76e41bd92
commit 87c2fd517d
No known key found for this signature in database
GPG Key ID: C6EEDEFD6CA07281
5 changed files with 17 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/dockview-core/src/__tests__/dockview/dockviewComponent.spec.ts
View File

@ -5823,9 +5823,9 @@ describe('dockviewComponent', () => {
});
});
test('onDidBlockPopout event is emitted', async () => {
test('onDidOpenPoputWindowFail event is emitted', async () => {
const onDidBlockPopoutHandler = jest.fn();
dockview.onDidBlockPopout(onDidBlockPopoutHandler);
dockview.onDidOpenPopoutWindowFail(onDidBlockPopoutHandler);
await dockview.addPopoutGroup(panel.group);

4
packages/dockview-core/src/api/component.api.ts
View File

@ -749,8 +749,8 @@ export class DockviewApi implements CommonApi<SerializedDockview> {
return this.component.onDidPopoutGroupPositionChange;
}
get onDidBlockPopout(): Event<void> {
return this.component.onDidBlockPopout;
get onDidOpenPopoutWindowFail(): Event<void> {
return this.component.onDidOpenPopoutWindowFail;
}
/**

3
packages/dockview-core/src/dockview/components/titlebar/tabs.ts
View File

@ -251,9 +251,6 @@ export class Tabs extends CompositeDisposable {
delete(id: string): void {
const index = this.indexOf(id);
const tabToRemove = this._tabs.splice(index, 1)[0];
if (!tabToRemove) {
return;
}
const { value, disposable } = tabToRemove;

17
packages/dockview-core/src/dockview/dockviewComponent.ts
View File

@ -226,7 +226,7 @@ export interface IDockviewComponent extends IBaseGrid<DockviewGroupPanel> {
readonly onDidMaximizedGroupChange: Event<DockviewMaximizedGroupChanged>;
readonly onDidPopoutGroupSizeChange: Event<PopoutGroupChangeSizeEvent>;
readonly onDidPopoutGroupPositionChange: Event<PopoutGroupChangePositionEvent>;
readonly onDidBlockPopout: Event<void>;
readonly onDidOpenPopoutWindowFail: Event<void>;
readonly options: DockviewComponentOptions;
updateOptions(options: DockviewOptions): void;
moveGroupOrPanel(options: MoveGroupOrPanelOptions): void;
@ -320,8 +320,9 @@ export class DockviewComponent
readonly onDidPopoutGroupPositionChange: Event<PopoutGroupChangePositionEvent> =
this._onDidPopoutGroupPositionChange.event;
private readonly _onDidBlockPopout = new Emitter<void>();
readonly onDidBlockPopout: Event<void> = this._onDidBlockPopout.event;
private readonly _onDidOpenPopoutWindowFail = new Emitter<void>();
readonly onDidOpenPopoutWindowFail: Event<void> =
this._onDidOpenPopoutWindowFail.event;
private readonly _onDidLayoutFromJSON = new Emitter<void>();
readonly onDidLayoutFromJSON: Event<void> = this._onDidLayoutFromJSON.event;
@ -509,7 +510,7 @@ export class DockviewComponent
this._onDidOptionsChange,
this._onDidPopoutGroupSizeChange,
this._onDidPopoutGroupPositionChange,
this._onDidBlockPopout,
this._onDidOpenPopoutWindowFail,
this.onDidViewVisibilityChangeMicroTaskQueue(() => {
this.updateWatermark();
}),
@ -744,8 +745,12 @@ export class DockviewComponent
}
if (popoutContainer === null) {
console.error(
'dockview: failed to create popout. perhaps you need to allow pop-ups for this website'
);
popoutWindowDisposable.dispose();
this._onDidBlockPopout.fire();
this._onDidOpenPopoutWindowFail.fire();
// if the popout window was blocked, we need to move the group back to the reference group
// and set it to visible
@ -988,7 +993,7 @@ export class DockviewComponent
return true;
})
.catch((err) => {
console.error('dockview: failed to create popout window', err);
console.error('dockview: failed to create popout.', err);
return false;
});
}

2
packages/docs/sandboxes/react/dockview/popout-group/src/app.tsx
View File

@ -143,7 +143,7 @@ export const App = (props: { theme?: string }) => {
const load = (api: DockviewApi) => {
api.clear();
api.onDidBlockPopout(() => {
api.onDidOpenPopoutWindowFail(() => {
console.log('Popout blocked');
});
if (layout) {