mirror of
https://github.com/mathuo/dockview
synced 2025-02-02 22:45:48 +00:00
Merge branch 'master' of https://github.com/madcodelife/dockview into 531-fixtypo-onlywhenvisibile-onlywhenvisible
This commit is contained in:
commit
78a5534bab
@ -68,7 +68,7 @@ describe('contentContainer', () => {
|
|||||||
|
|
||||||
const cut = new ContentContainer(
|
const cut = new ContentContainer(
|
||||||
fromPartial<DockviewComponent>({
|
fromPartial<DockviewComponent>({
|
||||||
renderer: 'onlyWhenVisibile',
|
renderer: 'onlyWhenVisible',
|
||||||
overlayRenderContainer,
|
overlayRenderContainer,
|
||||||
}),
|
}),
|
||||||
fromPartial<DockviewGroupPanelModel>({
|
fromPartial<DockviewGroupPanelModel>({
|
||||||
@ -91,7 +91,7 @@ describe('contentContainer', () => {
|
|||||||
view: {
|
view: {
|
||||||
content: contentRenderer,
|
content: contentRenderer,
|
||||||
},
|
},
|
||||||
api: { renderer: 'onlyWhenVisibile' },
|
api: { renderer: 'onlyWhenVisible' },
|
||||||
});
|
});
|
||||||
|
|
||||||
cut.openPanel(panel as IDockviewPanel);
|
cut.openPanel(panel as IDockviewPanel);
|
||||||
@ -126,7 +126,7 @@ describe('contentContainer', () => {
|
|||||||
view: {
|
view: {
|
||||||
content: contentRenderer2,
|
content: contentRenderer2,
|
||||||
} as Partial<IDockviewPanelModel>,
|
} as Partial<IDockviewPanelModel>,
|
||||||
api: { renderer: 'onlyWhenVisibile' },
|
api: { renderer: 'onlyWhenVisible' },
|
||||||
} as Partial<IDockviewPanel>;
|
} as Partial<IDockviewPanel>;
|
||||||
|
|
||||||
cut.openPanel(panel2 as IDockviewPanel);
|
cut.openPanel(panel2 as IDockviewPanel);
|
||||||
@ -153,7 +153,7 @@ describe('contentContainer', () => {
|
|||||||
disposable.dispose();
|
disposable.dispose();
|
||||||
});
|
});
|
||||||
|
|
||||||
test("that panels renderered as 'onlyWhenVisibile' are removed when closed", () => {
|
test("that panels renderered as 'onlyWhenVisible' are removed when closed", () => {
|
||||||
const overlayRenderContainer = fromPartial<OverlayRenderContainer>({
|
const overlayRenderContainer = fromPartial<OverlayRenderContainer>({
|
||||||
detatch: jest.fn(),
|
detatch: jest.fn(),
|
||||||
});
|
});
|
||||||
@ -169,14 +169,14 @@ describe('contentContainer', () => {
|
|||||||
|
|
||||||
const panel1 = fromPartial<IDockviewPanel>({
|
const panel1 = fromPartial<IDockviewPanel>({
|
||||||
api: {
|
api: {
|
||||||
renderer: 'onlyWhenVisibile',
|
renderer: 'onlyWhenVisible',
|
||||||
},
|
},
|
||||||
view: { content: new TestContentRenderer('panel_1') },
|
view: { content: new TestContentRenderer('panel_1') },
|
||||||
});
|
});
|
||||||
|
|
||||||
const panel2 = fromPartial<IDockviewPanel>({
|
const panel2 = fromPartial<IDockviewPanel>({
|
||||||
api: {
|
api: {
|
||||||
renderer: 'onlyWhenVisibile',
|
renderer: 'onlyWhenVisible',
|
||||||
},
|
},
|
||||||
view: { content: new TestContentRenderer('panel_2') },
|
view: { content: new TestContentRenderer('panel_2') },
|
||||||
});
|
});
|
||||||
|
@ -270,7 +270,7 @@ describe('dockviewGroupPanelModel', () => {
|
|||||||
options = {};
|
options = {};
|
||||||
|
|
||||||
panelApi = fromPartial<DockviewPanelApi>({
|
panelApi = fromPartial<DockviewPanelApi>({
|
||||||
renderer: 'onlyWhenVisibile',
|
renderer: 'onlyWhenVisible',
|
||||||
onDidTitleChange: new Emitter().event,
|
onDidTitleChange: new Emitter().event,
|
||||||
onDidParametersChange: new Emitter().event,
|
onDidParametersChange: new Emitter().event,
|
||||||
});
|
});
|
||||||
|
@ -43,7 +43,7 @@ describe('dockviewPanel', () => {
|
|||||||
group,
|
group,
|
||||||
model,
|
model,
|
||||||
{
|
{
|
||||||
renderer: 'onlyWhenVisibile',
|
renderer: 'onlyWhenVisible',
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
|
|
||||||
@ -102,7 +102,7 @@ describe('dockviewPanel', () => {
|
|||||||
group,
|
group,
|
||||||
model,
|
model,
|
||||||
{
|
{
|
||||||
renderer: 'onlyWhenVisibile',
|
renderer: 'onlyWhenVisible',
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
|
|
||||||
@ -157,7 +157,7 @@ describe('dockviewPanel', () => {
|
|||||||
group,
|
group,
|
||||||
model,
|
model,
|
||||||
{
|
{
|
||||||
renderer: 'onlyWhenVisibile',
|
renderer: 'onlyWhenVisible',
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
|
|
||||||
@ -203,7 +203,7 @@ describe('dockviewPanel', () => {
|
|||||||
group,
|
group,
|
||||||
model,
|
model,
|
||||||
{
|
{
|
||||||
renderer: 'onlyWhenVisibile',
|
renderer: 'onlyWhenVisible',
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
|
|
||||||
@ -250,7 +250,7 @@ describe('dockviewPanel', () => {
|
|||||||
group,
|
group,
|
||||||
model,
|
model,
|
||||||
{
|
{
|
||||||
renderer: 'onlyWhenVisibile',
|
renderer: 'onlyWhenVisible',
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
|
|
||||||
@ -295,7 +295,7 @@ describe('dockviewPanel', () => {
|
|||||||
group,
|
group,
|
||||||
model,
|
model,
|
||||||
{
|
{
|
||||||
renderer: 'onlyWhenVisibile',
|
renderer: 'onlyWhenVisible',
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
|
|
||||||
|
@ -132,7 +132,7 @@ export class ContentContainer
|
|||||||
let container: HTMLElement;
|
let container: HTMLElement;
|
||||||
|
|
||||||
switch (panel.api.renderer) {
|
switch (panel.api.renderer) {
|
||||||
case 'onlyWhenVisibile':
|
case 'onlyWhenVisible':
|
||||||
this.group.renderContainer.detatch(panel);
|
this.group.renderContainer.detatch(panel);
|
||||||
if (this.panel) {
|
if (this.panel) {
|
||||||
if (doRender) {
|
if (doRender) {
|
||||||
@ -198,7 +198,7 @@ export class ContentContainer
|
|||||||
|
|
||||||
public closePanel(): void {
|
public closePanel(): void {
|
||||||
if (this.panel) {
|
if (this.panel) {
|
||||||
if (this.panel.api.renderer === 'onlyWhenVisibile') {
|
if (this.panel.api.renderer === 'onlyWhenVisible') {
|
||||||
this.panel.view.content.element.parentElement?.removeChild(
|
this.panel.view.content.element.parentElement?.removeChild(
|
||||||
this.panel.view.content.element
|
this.panel.view.content.element
|
||||||
);
|
);
|
||||||
|
@ -426,7 +426,7 @@ export class DockviewComponent
|
|||||||
}
|
}
|
||||||
|
|
||||||
get renderer(): DockviewPanelRenderer {
|
get renderer(): DockviewPanelRenderer {
|
||||||
return this.options.defaultRenderer ?? 'onlyWhenVisibile';
|
return this.options.defaultRenderer ?? 'onlyWhenVisible';
|
||||||
}
|
}
|
||||||
|
|
||||||
constructor(options: DockviewComponentOptions) {
|
constructor(options: DockviewComponentOptions) {
|
||||||
|
@ -4,7 +4,7 @@ import { getDomNodePagePosition, toggleClass } from './dom';
|
|||||||
import { CompositeDisposable, Disposable, IDisposable } from './lifecycle';
|
import { CompositeDisposable, Disposable, IDisposable } from './lifecycle';
|
||||||
import { IDockviewPanel } from './dockview/dockviewPanel';
|
import { IDockviewPanel } from './dockview/dockviewPanel';
|
||||||
|
|
||||||
export type DockviewPanelRenderer = 'onlyWhenVisibile' | 'always';
|
export type DockviewPanelRenderer = 'onlyWhenVisible' | 'always';
|
||||||
|
|
||||||
export interface IRenderable {
|
export interface IRenderable {
|
||||||
readonly element: HTMLElement;
|
readonly element: HTMLElement;
|
||||||
|
@ -55,9 +55,9 @@ const components = {
|
|||||||
<button
|
<button
|
||||||
onClick={() => {
|
onClick={() => {
|
||||||
setMode(
|
setMode(
|
||||||
mode === 'onlyWhenVisibile'
|
mode === 'onlyWhenVisible'
|
||||||
? 'always'
|
? 'always'
|
||||||
: 'onlyWhenVisibile'
|
: 'onlyWhenVisible'
|
||||||
);
|
);
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
|
@ -22404,7 +22404,7 @@
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
"name": "defaultRenderer",
|
"name": "defaultRenderer",
|
||||||
"code": "'always' | 'onlyWhenVisibile'",
|
"code": "'always' | 'onlyWhenVisible'",
|
||||||
"kind": "property",
|
"kind": "property",
|
||||||
"type": {
|
"type": {
|
||||||
"type": "or",
|
"type": "or",
|
||||||
@ -22415,7 +22415,7 @@
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
"type": "literal",
|
"type": "literal",
|
||||||
"value": "onlyWhenVisibile"
|
"value": "onlyWhenVisible"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
},
|
},
|
||||||
@ -25927,7 +25927,7 @@
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
"name": "renderer",
|
"name": "renderer",
|
||||||
"code": "'always' | 'onlyWhenVisibile'",
|
"code": "'always' | 'onlyWhenVisible'",
|
||||||
"kind": "property",
|
"kind": "property",
|
||||||
"type": {
|
"type": {
|
||||||
"type": "or",
|
"type": "or",
|
||||||
@ -25938,7 +25938,7 @@
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
"type": "literal",
|
"type": "literal",
|
||||||
"value": "onlyWhenVisibile"
|
"value": "onlyWhenVisible"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
},
|
},
|
||||||
@ -39929,7 +39929,7 @@
|
|||||||
},
|
},
|
||||||
"DockviewPanelRenderer": {
|
"DockviewPanelRenderer": {
|
||||||
"name": "DockviewPanelRenderer",
|
"name": "DockviewPanelRenderer",
|
||||||
"code": "'always' | 'onlyWhenVisibile'",
|
"code": "'always' | 'onlyWhenVisible'",
|
||||||
"typeParameters": [],
|
"typeParameters": [],
|
||||||
"type": {
|
"type": {
|
||||||
"type": "or",
|
"type": "or",
|
||||||
@ -39940,7 +39940,7 @@
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
"type": "literal",
|
"type": "literal",
|
||||||
"value": "onlyWhenVisibile"
|
"value": "onlyWhenVisible"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
},
|
},
|
||||||
@ -41154,7 +41154,7 @@
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
"name": "defaultRenderer",
|
"name": "defaultRenderer",
|
||||||
"code": "'always' | 'onlyWhenVisibile'",
|
"code": "'always' | 'onlyWhenVisible'",
|
||||||
"kind": "property",
|
"kind": "property",
|
||||||
"type": {
|
"type": {
|
||||||
"type": "or",
|
"type": "or",
|
||||||
@ -41165,7 +41165,7 @@
|
|||||||
},
|
},
|
||||||
{
|
{
|
||||||
"type": "literal",
|
"type": "literal",
|
||||||
"value": "onlyWhenVisibile"
|
"value": "onlyWhenVisible"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
},
|
},
|
||||||
|
Loading…
Reference in New Issue
Block a user