diff --git a/packages/dockview-core/src/__tests__/dockview/components/watermark/watermark.spec.ts b/packages/dockview-core/src/__tests__/dockview/components/watermark/watermark.spec.ts index 662f73198..7ce6551e6 100644 --- a/packages/dockview-core/src/__tests__/dockview/components/watermark/watermark.spec.ts +++ b/packages/dockview-core/src/__tests__/dockview/components/watermark/watermark.spec.ts @@ -14,7 +14,6 @@ describe('watermark', () => { const group = jest.fn() as any; cut.init({ containerApi: api }); - cut.updateParentGroup(group, true); const closeEl = cut.element.querySelector('.close-action')!; diff --git a/packages/dockview-core/src/__tests__/dockview/dockviewGroupPanelModel.spec.ts b/packages/dockview-core/src/__tests__/dockview/dockviewGroupPanelModel.spec.ts index 1f83b8221..01d0c84d1 100644 --- a/packages/dockview-core/src/__tests__/dockview/dockviewGroupPanelModel.spec.ts +++ b/packages/dockview-core/src/__tests__/dockview/dockviewGroupPanelModel.spec.ts @@ -116,10 +116,6 @@ class Watermark implements IWatermarkRenderer { return {}; } - updateParentGroup() { - // - } - dispose() { // } diff --git a/packages/dockview-core/src/dockview/components/watermark/watermark.ts b/packages/dockview-core/src/dockview/components/watermark/watermark.ts index 28ecf9c7c..ca43401c7 100644 --- a/packages/dockview-core/src/dockview/components/watermark/watermark.ts +++ b/packages/dockview-core/src/dockview/components/watermark/watermark.ts @@ -78,10 +78,7 @@ export class Watermark this.render(); } - updateParentGroup(group: DockviewGroupPanel, _visible: boolean): void { - this._group = group; - this.render(); - } + dispose(): void { super.dispose(); diff --git a/packages/dockview-core/src/dockview/dockviewGroupPanelModel.ts b/packages/dockview-core/src/dockview/dockviewGroupPanelModel.ts index 574441eba..548cf9ef6 100644 --- a/packages/dockview-core/src/dockview/dockviewGroupPanelModel.ts +++ b/packages/dockview-core/src/dockview/dockviewGroupPanelModel.ts @@ -972,8 +972,6 @@ export class DockviewGroupPanelModel this.tabsContainer.hide(); this.contentContainer.element.appendChild(this.watermark.element); - - this.watermark.updateParentGroup(this.groupPanel, true); } if (!this.isEmpty && this.watermark) { this.watermark.element.remove(); diff --git a/packages/dockview-core/src/dockview/types.ts b/packages/dockview-core/src/dockview/types.ts index 99c7c38d9..0151381bd 100644 --- a/packages/dockview-core/src/dockview/types.ts +++ b/packages/dockview-core/src/dockview/types.ts @@ -32,7 +32,6 @@ export interface IWatermarkRenderer extends Optional, RendererMethodOptionalList> { readonly element: HTMLElement; init: (params: WatermarkRendererInitParameters) => void; - updateParentGroup(group: DockviewGroupPanel, visible: boolean): void; } export interface ITabRenderer diff --git a/packages/dockview-vue/src/utils.ts b/packages/dockview-vue/src/utils.ts index a4e18a5fe..4b6252899 100644 --- a/packages/dockview-vue/src/utils.ts +++ b/packages/dockview-vue/src/utils.ts @@ -183,10 +183,6 @@ export class VueWatermarkRenderer ); } - updateParentGroup(group: DockviewGroupPanel, visible: boolean): void { - // TODO: make optional on interface - } - update(event: PanelUpdateEvent): void { // noop } diff --git a/packages/dockview/src/dockview/reactWatermarkPart.ts b/packages/dockview/src/dockview/reactWatermarkPart.ts index f9b18a1c7..731ecd646 100644 --- a/packages/dockview/src/dockview/reactWatermarkPart.ts +++ b/packages/dockview/src/dockview/reactWatermarkPart.ts @@ -57,13 +57,6 @@ export class ReactWatermarkPart implements IWatermarkRenderer { // noop - retrieval from api } - updateParentGroup( - _group: DockviewGroupPanel, - _isPanelVisible: boolean - ): void { - // noop - } - dispose(): void { this.part?.dispose(); }