rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-05-01 17:18:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

bug: maximized group must be active

Browse Source
This commit is contained in:
mathuo 2024-02-09 21:02:39 +00:00
parent de93234632
commit 6b2ed70a7c
No known key found for this signature in database
GPG Key ID: C6EEDEFD6CA07281
2 changed files with 43 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
packages/dockview-core/src/__tests__/dockview/dockviewComponent.spec.ts
View File

@ -4554,4 +4554,46 @@ describe('dockviewComponent', () => {
expect(dockview.panels.length).toBe(3);
});
});
describe('maximized group', () => {
test('that a maximzied group is set to active', () => {
const container = document.createElement('div');
const dockview = new DockviewComponent({
parentElement: container,
components: {
default: PanelContentPartTest,
},
tabComponents: {
test_tab_id: PanelTabPartTest,
},
orientation: Orientation.HORIZONTAL,
});
dockview.layout(1000, 500);
const panel1 = dockview.addPanel({
id: 'panel_1',
component: 'default',
});
const panel2 = dockview.addPanel({
id: 'panel_2',
component: 'default',
position: { direction: 'right' },
});
expect(panel1.api.isActive).toBeFalsy();
expect(panel1.group.api.isActive).toBeFalsy();
expect(panel2.api.isActive).toBeTruthy();
expect(panel2.group.api.isActive).toBeTruthy();
panel1.api.maximize();
expect(panel1.api.isActive).toBeTruthy();
expect(panel1.group.api.isActive).toBeTruthy();
expect(panel2.api.isActive).toBeFalsy();
expect(panel2.group.api.isActive).toBeFalsy();
});
});
});

1
packages/dockview-core/src/gridview/baseComponentGridview.ts
View File

@ -194,6 +194,7 @@ export abstract class BaseGrid<T extends IGridPanelView>
maximizeGroup(panel: T): void {
this.gridview.maximizeView(panel);
this.doSetGroupActive(panel);
}
isMaximizedGroup(panel: T): boolean {