rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-02-13 11:55:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #334 from mathuo/321-add-hideclose-to-dockviewdefaulttab-component

Browse Source 
feat: override close option
This commit is contained in:
mathuo 2023-09-03 16:25:12 +01:00 committed by GitHub
commit 65a7da6a36
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 64 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
packages/dockview/src/__tests__/dockview/defaultTab.spec.tsx
View File

@ -40,6 +40,58 @@ describe('defaultTab', () => {
expect(element.querySelector('.dv-react-tab-close-btn')).toBeNull();
});
test('that settings closeActionOverride skips api.close()', async () => {
const api = fromPartial<DockviewPanelApi>({
close: jest.fn(),
});
const containerApi = fromPartial<DockviewApi>({});
const params = {};
const closeActionOverride = jest.fn();
render(
<DockviewDefaultTab
api={api}
containerApi={containerApi}
params={params}
closeActionOverride={closeActionOverride}
/>
);
const element = await screen.getByTestId('dockview-default-tab');
const btn = element.querySelector(
'.dv-react-tab-close-btn'
) as HTMLElement;
fireEvent.click(btn);
expect(closeActionOverride).toBeCalledTimes(1);
expect(api.close).toBeCalledTimes(0);
});
test('that clicking close calls api.close()', async () => {
const api = fromPartial<DockviewPanelApi>({
close: jest.fn(),
});
const containerApi = fromPartial<DockviewApi>({});
const params = {};
render(
<DockviewDefaultTab
api={api}
containerApi={containerApi}
params={params}
/>
);
const element = await screen.getByTestId('dockview-default-tab');
const btn = element.querySelector(
'.dv-react-tab-close-btn'
) as HTMLElement;
fireEvent.click(btn);
expect(api.close).toBeCalledTimes(1);
});
test('has close button when hideClose=false', async () => {
const api = fromPartial<DockviewPanelApi>({});
const containerApi = fromPartial<DockviewApi>({});

13
packages/dockview/src/dockview/defaultTab.tsx
View File

@ -3,7 +3,10 @@ import * as React from 'react';
import { CloseButton } from '../svg';
export type IDockviewDefaultTabProps = IDockviewPanelHeaderProps &
React.DOMAttributes<HTMLDivElement> & { hideClose?: boolean };
React.DOMAttributes<HTMLDivElement> & {
hideClose?: boolean;
closeActionOverride?: () => void;
};
export const DockviewDefaultTab: React.FunctionComponent<
IDockviewDefaultTabProps
@ -12,14 +15,20 @@ export const DockviewDefaultTab: React.FunctionComponent<
containerApi: _containerApi,
params: _params,
hideClose,
closeActionOverride,
...rest
}) => {
const onClose = React.useCallback(
(event: React.MouseEvent<HTMLSpanElement>) => {
event.preventDefault();
if (closeActionOverride) {
closeActionOverride();
} else {
api.close();
}
},
[api]
[api, closeActionOverride]
);
const onMouseDown = React.useCallback((e: React.MouseEvent) => {