rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-01-23 01:45:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: align event names

Browse Source
This commit is contained in:
mathuo 2024-01-28 13:43:09 +00:00
parent a8472e8b71
commit 6274708acb
No known key found for this signature in database
GPG Key ID: C6EEDEFD6CA07281
4 changed files with 19 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/dockview-core/src/api/component.api.ts
View File

@ -830,8 +830,8 @@ export class DockviewApi implements CommonApi<SerializedDockview> {
options?: {
position?: Box;
popoutUrl?: string;
onOpened?: (id: string, window: Window) => void;
onClosing?: (id: string, window: Window) => void;
onDidOpen?: (event: { id: string; window: Window }) => void;
onWillClose?: (event: { id: string; window: Window }) => void;
}
): void {
this.component.addPopoutGroup(item, options);

12
packages/dockview-core/src/dockview/dockviewComponent.ts
View File

@ -287,8 +287,8 @@ export interface IDockviewComponent extends IBaseGrid<DockviewGroupPanel> {
options?: {
position?: Box;
popoutUrl?: string;
onOpened?: (id: string, window: Window) => void;
onClosing?: (id: string, window: Window) => void;
onDidOpen?: (event: { id: string; window: Window }) => void;
onWillClose?: (event: { id: string; window: Window }) => void;
}
): void;
}
@ -516,8 +516,8 @@ export class DockviewComponent
skipRemoveGroup?: boolean;
position?: Box;
popoutUrl?: string;
onOpened?: (id: string, window: Window) => void;
onClosing?: (id: string, window: Window) => void;
onDidOpen?: (event: { id: string; window: Window }) => void;
onWillClose?: (event: { id: string; window: Window }) => void;
}
): void {
let group: DockviewGroupPanel;
@ -566,8 +566,8 @@ export class DockviewComponent
width: box.width,
height: box.height,
},
onOpened: options?.onOpened,
onClosing: options?.onClosing
onDidOpen: options?.onDidOpen,
onWillClose: options?.onWillClose,
}
);

8
packages/dockview-core/src/dockview/dockviewPopoutGroupPanel.ts
View File

@ -13,8 +13,8 @@ export class DockviewPopoutGroupPanel extends CompositeDisposable {
className: string;
popoutUrl: string;
box: Box;
onOpened?: (id: string, window: Window) => void;
onClosing?: (id: string, window: Window) => void;
onDidOpen?: (event: { id: string; window: Window }) => void;
onWillClose?: (event: { id: string; window: Window }) => void;
}
) {
super();
@ -25,8 +25,8 @@ export class DockviewPopoutGroupPanel extends CompositeDisposable {
top: this.options.box.top,
width: this.options.box.width,
height: this.options.box.height,
onOpened: this.options.onOpened,
onClosing: this.options.onClosing,
onDidOpen: this.options.onDidOpen,
onWillClose: this.options.onWillClose,
});
group.model.location = {

15
packages/dockview-core/src/popoutWindow.ts
View File

@ -5,8 +5,8 @@ import { Box } from './types';
export type PopoutWindowOptions = {
url: string;
onOpened?: (id: string, window: Window) => void;
onClosing?: (id: string, window: Window) => void;
onDidOpen?: (event: { id: string; window: Window }) => void;
onWillClose?: (event: { id: string; window: Window }) => void;
} & Box;
export class PopoutWindow extends CompositeDisposable {
@ -53,9 +53,10 @@ export class PopoutWindow extends CompositeDisposable {
if (this._window) {
this._onWillClose.fire();
if (this.options.onClosing) {
this.options.onClosing(this.target, this._window.value);
}
this.options.onWillClose?.({
id: this.target,
window: this._window.value,
});
this._window.disposable.dispose();
this._window.value.close();
@ -132,9 +133,7 @@ export class PopoutWindow extends CompositeDisposable {
});
});
if (this.options.onOpened) {
this.options.onOpened(this.target, externalWindow);
}
this.options.onDidOpen?.({ id: this.target, window: externalWindow });
}
private createPopoutWindowContainer(): HTMLElement {