From 5555005de0ba7c451b5292c99674724ec3e7f5c5 Mon Sep 17 00:00:00 2001 From: mathuo <{ID}+{username}@users.noreply.github.com> Date: Sat, 5 Jun 2021 16:17:50 +0100 Subject: [PATCH] fix: tests --- .../src/__tests__/groupview/groupview.spec.ts | 20 +++++++++++++++++-- .../components/watermark/watermark.ts | 19 +++++++++++++++--- .../src/react/splitview/splitview.tsx | 2 +- 3 files changed, 35 insertions(+), 6 deletions(-) diff --git a/packages/dockview/src/__tests__/groupview/groupview.spec.ts b/packages/dockview/src/__tests__/groupview/groupview.spec.ts index c9e3e5027..248e2c5ca 100644 --- a/packages/dockview/src/__tests__/groupview/groupview.spec.ts +++ b/packages/dockview/src/__tests__/groupview/groupview.spec.ts @@ -9,7 +9,7 @@ import { GroupPanelPartInitParameters, IContentRenderer, ITabRenderer, - WatermarkPart, + IWatermarkRenderer, } from '../../groupview/types'; import { PanelUpdateEvent } from '../../panel/types'; import { fireEvent } from '@testing-library/dom'; @@ -23,7 +23,7 @@ import { import { GroupOptions, GroupDropEvent } from '../../groupview/groupview'; import { DockviewPanelApi } from '../../api/groupPanelApi'; -class Watermark implements WatermarkPart { +class Watermark implements IWatermarkRenderer { public readonly element = document.createElement('div'); get id() { @@ -34,6 +34,22 @@ class Watermark implements WatermarkPart { // } + layout(width: number, height: number) { + // noop + } + + update(event: PanelUpdateEvent) { + // noop + } + + focus() { + // noop + } + + toJSON() { + return {}; + } + updateParentGroup() { // } diff --git a/packages/dockview/src/dockview/components/watermark/watermark.ts b/packages/dockview/src/dockview/components/watermark/watermark.ts index 31403d959..30f0f3015 100644 --- a/packages/dockview/src/dockview/components/watermark/watermark.ts +++ b/packages/dockview/src/dockview/components/watermark/watermark.ts @@ -7,6 +7,7 @@ import { addDisposableListener } from '../../../events'; import { toggleClass } from '../../../dom'; import { CompositeDisposable } from '../../../lifecycle'; import { GroupviewPanel } from '../../../groupview/groupviewPanel'; +import { PanelUpdateEvent } from '../../../panel/types'; export class Watermark extends CompositeDisposable @@ -55,11 +56,23 @@ export class Watermark ); } + update(event: PanelUpdateEvent) { + // noop + } + + focus() { + // noop + } + + toJSON() { + return {}; + } + layout(width: number, height: number) { // noop } - public init(params: GroupPanelPartInitParameters) { + init(params: GroupPanelPartInitParameters) { this.params = params; this.addDisposables( @@ -71,7 +84,7 @@ export class Watermark this.render(); } - public updateParentGroup(group: GroupviewPanel, visible: boolean): void { + updateParentGroup(group: GroupviewPanel, visible: boolean): void { this.group = group; this.render(); } @@ -87,7 +100,7 @@ export class Watermark toggleClass(this.element, 'has-actions', isOneGroup); } - public dispose() { + dispose() { super.dispose(); } } diff --git a/packages/dockview/src/react/splitview/splitview.tsx b/packages/dockview/src/react/splitview/splitview.tsx index 738dad84c..87c11c27e 100644 --- a/packages/dockview/src/react/splitview/splitview.tsx +++ b/packages/dockview/src/react/splitview/splitview.tsx @@ -15,7 +15,7 @@ export interface SplitviewReadyEvent { api: SplitviewApi; } -export interface ISplitviewPanelProps> +export interface ISplitviewPanelProps extends PanelParameters { api: SplitviewPanelApi; containerApi: SplitviewApi;