rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-02-13 03:45:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #789 from mathuo/788-sonar-fixes

Browse Source 
chore: adjust sonar parameters
This commit is contained in:
mathuo 2024-12-10 20:20:29 +00:00 committed by GitHub
commit 429177436e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 13 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/main.yml vendored
View File

@ -27,7 +27,7 @@ jobs:
- run: npm run build - run: npm run build
- run: npm run test:cov - run: npm run test:cov
- name: SonarCloud Scan - name: SonarCloud Scan
uses: SonarSource/sonarcloud-github-action@master uses: sonarsource/sonarqube-scan-action@v4.1.0
env: env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

13
packages/dockview-core/src/dockview/dockviewComponent.ts
View File

@ -767,15 +767,16 @@ export class DockviewComponent
let returnedGroup: DockviewGroupPanel | undefined; let returnedGroup: DockviewGroupPanel | undefined;
const isValidReferenceGroup =
isGroupAddedToDom &&
referenceGroup &&
this.getPanel(referenceGroup.id);
const value = { const value = {
window: _window, window: _window,
popoutGroup: group, popoutGroup: group,
referenceGroup: !isGroupAddedToDom referenceGroup: isValidReferenceGroup
? undefined ? referenceGroup.id
: referenceGroup
? this.getPanel(referenceGroup.id)
? referenceGroup.id
: undefined
: undefined, : undefined,
disposable: { disposable: {
dispose: () => { dispose: () => {

8
packages/dockview-core/src/gridview/baseComponentGridview.ts
View File

@ -1,10 +1,5 @@
import { Emitter, Event, AsapEvent } from '../events'; import { Emitter, Event, AsapEvent } from '../events';
import { import { getGridLocation, Gridview, IGridView } from './gridview';
getGridLocation,
Gridview,
IGridView,
MaximizedViewChanged,
} from './gridview';
import { Position } from '../dnd/droptarget'; import { Position } from '../dnd/droptarget';
import { Disposable, IDisposable, IValueDisposable } from '../lifecycle'; import { Disposable, IDisposable, IValueDisposable } from '../lifecycle';
import { sequentialNumberGenerator } from '../math'; import { sequentialNumberGenerator } from '../math';
@ -13,7 +8,6 @@ import { IPanel } from '../panel/types';
import { MovementOptions2 } from '../dockview/options'; import { MovementOptions2 } from '../dockview/options';
import { Resizable } from '../resizable'; import { Resizable } from '../resizable';
import { Classnames } from '../dom'; import { Classnames } from '../dom';
import { IGridviewComponent } from './gridviewComponent';
const nextLayoutId = sequentialNumberGenerator(); const nextLayoutId = sequentialNumberGenerator();

2
packages/dockview-core/src/popoutWindow.ts
View File

@ -160,7 +160,7 @@ export class PopoutWindow extends CompositeDisposable {
resolve(container); resolve(container);
} catch (err) { } catch (err) {
// only except this is the DOM isn't setup. e.g. in a in correctly configured test // only except this is the DOM isn't setup. e.g. in a in correctly configured test
reject(err); reject(err as Error);
} }
}); });
}); });

6
sonar-project.properties
View File

@ -1,9 +1,9 @@
sonar.projectKey=mathuo_dockview sonar.projectKey=mathuo_dockview
sonar.organization=dockview sonar.organization=dockview
sonar.inclusions=packages/dockview/src/**/*,packages/dockview-core/src/**/*,packages/dockview-vue/src/**/* sonar.inclusions=packages/dockview/src/**/*,packages/dockview-core/src/**/*,packages/dockview-vue/src/**/*,packages/dockview-react/src/**/*
sonar.exclusions=packages/dockview/src/__tests__/**,packages/dockview-core/src/__tests__/**,packages/dockview-vue/src/__tests__/** sonar.exclusions=packages/dockview/docs/**/*,packages/dockview/src/__tests__/**/*,packages/dockview-core/src/__tests__/**/*,packages/dockview-vue/src/__tests__/**/*,packages/dockview-react/src/__tests__/**/*
sonar.tests=packages/dockview/src/__tests__,packages/dockview-core/src/__tests__,packages/dockview-vue/src/__tests__ sonar.tests=packages/dockview/src/__tests__,packages/dockview-core/src/__tests__,packages/dockview-vue/src/__tests__,packages/dockview-react/src/__tests__
sonar.testExecutionReportPaths=test-report.xml sonar.testExecutionReportPaths=test-report.xml
sonar.javascript.lcov.reportPaths=coverage/lcov.info sonar.javascript.lcov.reportPaths=coverage/lcov.info