Merge pull request #789 from mathuo/788-sonar-fixes

chore: adjust sonar parameters

.github/workflows/main.yml

@@ -27,7 +27,7 @@ jobs:
             - run: npm run build
             - run: npm run test:cov
             - name: SonarCloud Scan
-              uses: SonarSource/sonarcloud-github-action@master
+              uses: sonarsource/sonarqube-scan-action@v4.1.0
               env:
                   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
                   SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

packages/dockview-core/src/dockview/dockviewComponent.ts

@@ -767,15 +767,16 @@ export class DockviewComponent
 
                 let returnedGroup: DockviewGroupPanel | undefined;
 
+                const isValidReferenceGroup =
+                    isGroupAddedToDom &&
+                    referenceGroup &&
+                    this.getPanel(referenceGroup.id);
+
                 const value = {
                     window: _window,
                     popoutGroup: group,
-                    referenceGroup: !isGroupAddedToDom
-                        ? undefined
-                        : referenceGroup
-                        ? this.getPanel(referenceGroup.id)
-                            ? referenceGroup.id
-                            : undefined
+                    referenceGroup: isValidReferenceGroup
+                        ? referenceGroup.id
                         : undefined,
                     disposable: {
                         dispose: () => {

packages/dockview-core/src/gridview/baseComponentGridview.ts

@@ -1,10 +1,5 @@
 import { Emitter, Event, AsapEvent } from '../events';
-import {
-    getGridLocation,
-    Gridview,
-    IGridView,
-    MaximizedViewChanged,
-} from './gridview';
+import { getGridLocation, Gridview, IGridView } from './gridview';
 import { Position } from '../dnd/droptarget';
 import { Disposable, IDisposable, IValueDisposable } from '../lifecycle';
 import { sequentialNumberGenerator } from '../math';
@@ -13,7 +8,6 @@ import { IPanel } from '../panel/types';
 import { MovementOptions2 } from '../dockview/options';
 import { Resizable } from '../resizable';
 import { Classnames } from '../dom';
-import { IGridviewComponent } from './gridviewComponent';
 
 const nextLayoutId = sequentialNumberGenerator();
 

packages/dockview-core/src/popoutWindow.ts

@@ -160,7 +160,7 @@ export class PopoutWindow extends CompositeDisposable {
                     resolve(container);
                 } catch (err) {
                     // only except this is the DOM isn't setup. e.g. in a in correctly configured test
-                    reject(err);
+                    reject(err as Error);
                 }
             });
         });

sonar-project.properties

@@ -1,9 +1,9 @@
 sonar.projectKey=mathuo_dockview
 sonar.organization=dockview
 
-sonar.inclusions=packages/dockview/src/**/*,packages/dockview-core/src/**/*,packages/dockview-vue/src/**/*
-sonar.exclusions=packages/dockview/src/__tests__/**,packages/dockview-core/src/__tests__/**,packages/dockview-vue/src/__tests__/**
-sonar.tests=packages/dockview/src/__tests__,packages/dockview-core/src/__tests__,packages/dockview-vue/src/__tests__
+sonar.inclusions=packages/dockview/src/**/*,packages/dockview-core/src/**/*,packages/dockview-vue/src/**/*,packages/dockview-react/src/**/*
+sonar.exclusions=packages/dockview/docs/**/*,packages/dockview/src/__tests__/**/*,packages/dockview-core/src/__tests__/**/*,packages/dockview-vue/src/__tests__/**/*,packages/dockview-react/src/__tests__/**/*
+sonar.tests=packages/dockview/src/__tests__,packages/dockview-core/src/__tests__,packages/dockview-vue/src/__tests__,packages/dockview-react/src/__tests__
 
 sonar.testExecutionReportPaths=test-report.xml
 sonar.javascript.lcov.reportPaths=coverage/lcov.info