feat: rename event to nativeEvent to avoid event.event calls

This commit is contained in:
mathuo 2022-02-22 19:49:58 +00:00
parent 929690e730
commit 3dbe00d2a1
No known key found for this signature in database
GPG Key ID: C6EEDEFD6CA07281
3 changed files with 5 additions and 10 deletions

View File

@ -3,11 +3,6 @@ import { Emitter, Event } from '../events';
import { CompositeDisposable } from '../lifecycle'; import { CompositeDisposable } from '../lifecycle';
import { DragAndDropObserver } from './dnd'; import { DragAndDropObserver } from './dnd';
export interface DroptargetEvent {
position: Position;
event: DragEvent;
}
export enum Position { export enum Position {
Top = 'Top', Top = 'Top',
Left = 'Left', Left = 'Left',
@ -18,7 +13,7 @@ export enum Position {
export interface DroptargetEvent { export interface DroptargetEvent {
position: Position; position: Position;
event: DragEvent; nativeEvent: DragEvent;
} }
export type DropTargetDirections = 'vertical' | 'horizontal' | 'all' | 'none'; export type DropTargetDirections = 'vertical' | 'horizontal' | 'all' | 'none';
@ -174,7 +169,7 @@ export class Droptarget extends CompositeDisposable {
this.removeDropTarget(); this.removeDropTarget();
if (state) { if (state) {
this._onDrop.fire({ position: state, event: e }); this._onDrop.fire({ position: state, nativeEvent: e });
} }
}, },
}) })

View File

@ -224,7 +224,7 @@ export class Groupview extends CompositeDisposable implements IGroupview {
// noop // noop
}), }),
this.dropTarget.onDrop((event) => { this.dropTarget.onDrop((event) => {
this.handleDropEvent(event.event, event.position); this.handleDropEvent(event.nativeEvent, event.position);
}) })
); );
} }

View File

@ -173,7 +173,7 @@ export class TabsContainer
this.addDisposables( this.addDisposables(
this.voidDropTarget.onDrop((event) => { this.voidDropTarget.onDrop((event) => {
this._onDrop.fire({ this._onDrop.fire({
event: event.event, event: event.nativeEvent,
index: this.tabs.length, index: this.tabs.length,
}); });
}), }),
@ -271,7 +271,7 @@ export class TabsContainer
}), }),
tabToAdd.onDrop((event) => { tabToAdd.onDrop((event) => {
this._onDrop.fire({ this._onDrop.fire({
event: event.event, event: event.nativeEvent,
index: this.tabs.findIndex((x) => x.value === tabToAdd), index: this.tabs.findIndex((x) => x.value === tabToAdd),
}); });
}) })