From 34d8317ec54b08d9f1126ac798bb27af107a1fd4 Mon Sep 17 00:00:00 2001 From: mathuo <6710312+mathuo@users.noreply.github.com> Date: Sun, 19 Jun 2022 20:19:37 +0100 Subject: [PATCH] chore: remove circular dependency --- packages/dockview/src/dockview/components/tab/defaultTab.ts | 3 ++- packages/dockview/src/react/dockview/dockview.tsx | 3 +-- packages/dockview/src/react/dockview/reactHeaderPart.ts | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/dockview/src/dockview/components/tab/defaultTab.ts b/packages/dockview/src/dockview/components/tab/defaultTab.ts index 69bfff5c6..3d228e216 100644 --- a/packages/dockview/src/dockview/components/tab/defaultTab.ts +++ b/packages/dockview/src/dockview/components/tab/defaultTab.ts @@ -7,7 +7,8 @@ import { addDisposableListener } from '../../../events'; import { PanelUpdateEvent } from '../../../panel/types'; import { GroupPanel } from '../../../groupview/groupviewPanel'; import { createCloseButton } from '../../../svg'; -import { DEFAULT_TAB_IDENTIFIER } from '../../../react'; + +export const DEFAULT_TAB_IDENTIFIER = '__default__tab__'; export class DefaultTab extends CompositeDisposable implements ITabRenderer { private _element: HTMLElement; diff --git a/packages/dockview/src/react/dockview/dockview.tsx b/packages/dockview/src/react/dockview/dockview.tsx index 5cda82aa1..2f2eef738 100644 --- a/packages/dockview/src/react/dockview/dockview.tsx +++ b/packages/dockview/src/react/dockview/dockview.tsx @@ -24,8 +24,7 @@ import { ReactGroupControlsRendererPart, } from './groupControlsRenderer'; import { GroupPanel } from '../../groupview/groupviewPanel'; - -export const DEFAULT_TAB_IDENTIFIER = '__default__tab__'; +import { DEFAULT_TAB_IDENTIFIER } from '../../dockview/components/tab/defaultTab'; function createGroupControlElement( component: React.FunctionComponent | undefined, diff --git a/packages/dockview/src/react/dockview/reactHeaderPart.ts b/packages/dockview/src/react/dockview/reactHeaderPart.ts index 44a1b49e7..b2f137ea8 100644 --- a/packages/dockview/src/react/dockview/reactHeaderPart.ts +++ b/packages/dockview/src/react/dockview/reactHeaderPart.ts @@ -6,7 +6,8 @@ import { import { GroupPanel } from '../../groupview/groupviewPanel'; import { PanelUpdateEvent } from '../../panel/types'; import { ReactPart, ReactPortalStore } from '../react'; -import { DEFAULT_TAB_IDENTIFIER, IGroupPanelBaseProps } from './dockview'; +import { IGroupPanelBaseProps } from './dockview'; +import { DEFAULT_TAB_IDENTIFIER } from '../../dockview/components/tab/defaultTab'; export class ReactPanelHeaderPart implements ITabRenderer { private _element: HTMLElement;