rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-08-01 23:06:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove legacy code

Browse Source
This commit is contained in:
mathuo 2023-03-14 07:46:29 +03:00
parent 1b6c2ba92c
commit 1134f972d3
No known key found for this signature in database
GPG Key ID: C6EEDEFD6CA07281
8 changed files with 16 additions and 76 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/dockview-core/src/__tests__/__mocks__/mockDockviewPanelMode.ts
View File

@ -29,13 +29,6 @@ export class DockviewPanelModelMock implements IDockviewPanelModel {
//
}
updateParentGroup(
group: DockviewGroupPanel,
isPanelVisible: boolean
): void {
//
}
dispose(): void {
//
}

35
packages/dockview-core/src/dockview/components/tab/defaultTab.ts
View File

@ -7,9 +7,6 @@ import { createCloseButton } from '../../../svg';
export class DefaultTab extends CompositeDisposable implements ITabRenderer {
private _element: HTMLElement;
private _isPanelVisible = false;
private _isGroupActive = false;
private _content: HTMLElement;
private _actionContainer: HTMLElement;
private _list: HTMLElement;
@ -17,7 +14,7 @@ export class DefaultTab extends CompositeDisposable implements ITabRenderer {
//
private params: GroupPanelPartInitParameters = {} as any;
get element() {
get element(): HTMLElement {
return this._element;
}
@ -55,16 +52,16 @@ export class DefaultTab extends CompositeDisposable implements ITabRenderer {
this.render();
}
public update(event: PanelUpdateEvent) {
public update(event: PanelUpdateEvent): void {
this.params = { ...this.params, ...event.params };
this.render();
}
focus() {
focus(): void {
//noop
}
public init(params: GroupPanelPartInitParameters) {
public init(params: GroupPanelPartInitParameters): void {
this.params = params;
this._content.textContent = params.title;
@ -74,27 +71,19 @@ export class DefaultTab extends CompositeDisposable implements ITabRenderer {
});
}
public updateParentGroup(
group: DockviewGroupPanel,
isPanelVisible: boolean
) {
const changed =
this._isPanelVisible !== isPanelVisible ||
this._isGroupActive !== group.isActive;
this._isPanelVisible = isPanelVisible;
this._isGroupActive = group.isActive;
if (changed) {
this.render();
}
onGroupChange(_group: DockviewGroupPanel): void {
this.render();
}
public layout(_width: number, _height: number) {
onPanelVisibleChange(_isPanelVisible: boolean): void {
this.render();
}
public layout(_width: number, _height: number): void {
// noop
}
private render() {
private render(): void {
if (this._content.textContent !== this.params.title) {
this._content.textContent = this.params.title;
}

2
packages/dockview-core/src/dockview/dockviewPanel.ts
View File

@ -155,7 +155,7 @@ export class DockviewPanel
isVisible: isPanelVisible,
});
this.view?.updateParentGroup(
this.view.updateParentGroup(
this._group,
this._group.model.isPanelActive(this)
);

9
packages/dockview/src/dockview/reactContentPart.ts
View File

@ -13,8 +13,6 @@ import {
export class ReactPanelContentPart implements IContentRenderer {
private _element: HTMLElement;
private part?: ReactPart<IDockviewPanelProps>;
//
private _group: DockviewGroupPanel | undefined;
private readonly _onDidFocus = new DockviewEmitter<void>();
readonly onDidFocus: DockviewEvent<void> = this._onDidFocus.event;
@ -56,13 +54,6 @@ export class ReactPanelContentPart implements IContentRenderer {
this.part?.update(event.params);
}
public updateParentGroup(
group: DockviewGroupPanel,
_isPanelVisible: boolean
): void {
this._group = group;
}
public layout(_width: number, _height: number): void {
// noop
}

7
packages/dockview/src/dockview/reactHeaderPart.ts
View File

@ -50,13 +50,6 @@ export class ReactPanelHeaderPart implements ITabRenderer {
// noop - retrieval from api
}
public updateParentGroup(
_group: DockviewGroupPanel,
_isPanelVisible: boolean
): void {
// noop - retrieval from api
}
public dispose(): void {
this.part?.dispose();
}

14
packages/dockview/src/dockview/reactWatermarkPart.ts
View File

@ -15,9 +15,6 @@ export interface IWatermarkPanelProps extends IGroupPanelBaseProps {
export class ReactWatermarkPart implements IWatermarkRenderer {
private _element: HTMLElement;
private part?: ReactPart<IWatermarkPanelProps>;
private _groupRef: { value: DockviewGroupPanel | undefined } = {
value: undefined,
};
private parameters: GroupPanelPartInitParameters | undefined;
get element(): HTMLElement {
@ -45,11 +42,7 @@ export class ReactWatermarkPart implements IWatermarkRenderer {
api: parameters.api,
containerApi: parameters.containerApi,
close: () => {
if (this._groupRef.value) {
parameters.containerApi.removeGroup(
this._groupRef.value
);
}
parameters.containerApi.removeGroup(parameters.api.group);
},
}
);
@ -72,11 +65,10 @@ export class ReactWatermarkPart implements IWatermarkRenderer {
}
updateParentGroup(
group: DockviewGroupPanel,
_group: DockviewGroupPanel,
_isPanelVisible: boolean
): void {
// noop - retrieval from api
this._groupRef.value = group;
// noop
}
dispose(): void {

10
packages/dockview/src/dockview/v2/reactContentRenderer.ts
View File

@ -11,11 +11,8 @@ import { IDockviewPanelProps } from '../dockview';
export class ReactContentRenderer implements IContentRenderer {
private _hostedContainer: HostedContainer;
private _element: HTMLElement;
private part?: ReactPart<IDockviewPanelProps>;
private _group: DockviewGroupPanel | undefined;
private parameters: GroupPanelPartInitParameters | undefined;
get element(): HTMLElement {
@ -83,13 +80,6 @@ export class ReactContentRenderer implements IContentRenderer {
this.part?.update(params.params);
}
public updateParentGroup(
group: DockviewGroupPanel,
_isPanelVisible: boolean
): void {
this._group = group;
}
public layout(_width: number, _height: number): void {
this._hostedContainer.layout(this.element);
}

8
packages/dockview/src/dockview/v2/webviewContentRenderer.ts
View File

@ -9,7 +9,6 @@ import {
export class WebviewContentRenderer implements IContentRenderer {
private _hostedContainer: HostedContainer;
private _element: HTMLElement;
private parameters: GroupPanelPartInitParameters | undefined;
get element(): HTMLElement {
@ -38,13 +37,6 @@ export class WebviewContentRenderer implements IContentRenderer {
}
}
public updateParentGroup(
_group: DockviewGroupPanel,
_isPanelVisible: boolean
): void {
//
}
public layout(_width: number, _height: number): void {
this._hostedContainer.layout(this._element);
}