rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-03-10 07:52:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'master' of https://github.com/mathuo/dockview into 739-sonar-code-cleanup

Browse Source
This commit is contained in:
mathuo 2024-10-29 20:24:16 +00:00
commit 112dc2e2a9
No known key found for this signature in database
GPG Key ID: C6EEDEFD6CA07281
1 changed files with 0 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
packages/dockview/src/dockview/dockview.tsx
View File

@ -13,7 +13,6 @@ import {
PROPERTY_KEYS, PROPERTY_KEYS,
DockviewComponentOptions, DockviewComponentOptions,
DockviewFrameworkOptions, DockviewFrameworkOptions,
DockviewDndOverlayEvent,
DockviewReadyEvent, DockviewReadyEvent,
createDockview, createDockview,
} from 'dockview-core'; } from 'dockview-core';
@ -56,10 +55,6 @@ export interface IDockviewReactProps extends DockviewOptions {
onReady: (event: DockviewReadyEvent) => void; onReady: (event: DockviewReadyEvent) => void;
onDidDrop?: (event: DockviewDidDropEvent) => void; onDidDrop?: (event: DockviewDidDropEvent) => void;
onWillDrop?: (event: DockviewWillDropEvent) => void; onWillDrop?: (event: DockviewWillDropEvent) => void;
/**
* @deprecated use `api.onUnhandledDragOverEvent` instead. This will be removed in the next release.
*/
showDndOverlay?: (event: DockviewDndOverlayEvent) => boolean;
} }
function extractCoreOptions(props: IDockviewReactProps): DockviewOptions { function extractCoreOptions(props: IDockviewReactProps): DockviewOptions {
@ -203,26 +198,6 @@ export const DockviewReact = React.forwardRef(
}; };
}, [props.onDidDrop]); }, [props.onDidDrop]);
React.useEffect(() => {
if (!dockviewRef.current) {
return () => {
// noop
};
}
const disposable = dockviewRef.current.onUnhandledDragOverEvent(
(event) => {
if (props.showDndOverlay?.(event)) {
event.accept();
}
}
);
return () => {
disposable.dispose();
};
}, [props.showDndOverlay]);
React.useEffect(() => { React.useEffect(() => {
if (!dockviewRef.current) { if (!dockviewRef.current) {
return () => { return () => {