Merge pull request #870 from mathuo/866-splitviewreact-rendered-twice-in-react-strict-mode

bug: remove element after dispose

packages/dockview-core/src/__tests__/gridview/gridviewComponent.spec.ts

@@ -524,7 +524,7 @@ describe('gridview', () => {
 
         gridview.dispose();
 
-        expect(container.childNodes.length).toBe(0);
+        expect(container.children.length).toBe(0);
     });
 
     test('#1/VERTICAL', () => {

packages/dockview-core/src/__tests__/paneview/paneviewComponent.spec.ts

@@ -86,6 +86,7 @@ describe('componentPaneview', () => {
         paneview.dispose();
 
         expect(container.parentElement).toBe(root);
+        expect(container.children.length).toBe(0);
     });
 
     test('vertical panels', () => {

packages/dockview-core/src/__tests__/splitview/splitviewComponent.spec.ts

@@ -46,6 +46,7 @@ describe('componentSplitview', () => {
         splitview.dispose();
 
         expect(container.parentElement).toBe(root);
+        expect(container.children.length).toBe(0);
     });
 
     test('event leakage', () => {

packages/dockview-core/src/paneview/paneviewComponent.ts

@@ -476,6 +476,8 @@ export class PaneviewComponent extends Resizable implements IPaneviewComponent {
         }
         this._viewDisposables.clear();
 
+        this.element.remove();
+
         this.paneview.dispose();
     }
 }

packages/dockview-core/src/splitview/splitviewComponent.ts

@@ -425,6 +425,8 @@ export class SplitviewComponent
             view.dispose();
         }
 
+        this.element.remove();
+
         super.dispose();
     }
 }