rei-mirrors/dockview
1
0
Fork 0
mirror of https://github.com/mathuo/dockview synced 2025-03-09 23:42:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #655 from mathuo/654-resize

Browse Source 
bug: fix layout force flag
This commit is contained in:
mathuo 2024-07-17 22:33:50 +01:00 committed by GitHub
commit 0211148b66
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
packages/dockview-core/src/__tests__/gridview/baseComponentGridview.spec.ts
View File

@ -66,6 +66,8 @@ class TestPanel implements IGridPanelView {
}
class ClassUnderTest extends BaseGrid<TestPanel> {
readonly gridview = this.gridview;
constructor(options: BaseGridOptions) {
super(options);
}
@ -103,6 +105,31 @@ class ClassUnderTest extends BaseGrid<TestPanel> {
}
describe('baseComponentGridview', () => {
test('that .layout(...) force flag works', () => {
const cut = new ClassUnderTest({
parentElement: document.createElement('div'),
orientation: Orientation.HORIZONTAL,
proportionalLayout: true,
});
const spy = jest.spyOn(cut.gridview, 'layout');
cut.layout(100, 100);
expect(spy).toHaveBeenCalledTimes(1);
cut.layout(100, 100, false);
expect(spy).toHaveBeenCalledTimes(1);
cut.layout(100, 100, true);
expect(spy).toHaveBeenCalledTimes(2);
cut.layout(150, 150, false);
expect(spy).toHaveBeenCalledTimes(3);
cut.layout(150, 150, true);
expect(spy).toHaveBeenCalledTimes(4);
});
test('can add group', () => {
const cut = new ClassUnderTest({
parentElement: document.createElement('div'),

2
packages/dockview-core/src/gridview/baseComponentGridview.ts
View File

@ -323,7 +323,7 @@ export abstract class BaseGrid<T extends IGridPanelView>
public layout(width: number, height: number, forceResize?: boolean): void {
const different =
forceResize ?? (width !== this.width || height !== this.height);
forceResize || width !== this.width || height !== this.height;
if (!different) {
return;