rei-mirrors/Fornjot
1
0
Fork 0
mirror of https://github.com/hannobraun/Fornjot synced 2025-07-28 12:56:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove confusing and wrong comment

Browse Source 
I don't see how the half-edges that bound a sphere would be any less
tied to curvature than those that define a cylinder.
This commit is contained in:
Hanno Braun 2024-07-30 18:58:07 +02:00
parent d878bc8cd6
commit dba6d72d1e
1 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
crates/fj-core/src/algorithms/approx/face.rs
View File

@ -72,19 +72,6 @@ pub fn approx_face(
) -> FaceApprox { ) -> FaceApprox {
let tolerance = tolerance.into(); let tolerance = tolerance.into();
// Curved faces whose curvature is not fully defined by their edges
// are not supported yet. For that reason, we can fully ignore `face`'s
// `surface` field and just pass the edges to `Self::for_edges`.
//
// An example of a curved face that is supported, is the cylinder. Its
// curvature is fully defined be the edges (circles) that border it. The
// circle approximations are sufficient to triangulate the surface.
//
// An example of a curved face that is currently not supported, and thus
// doesn't need to be handled here, is a sphere. A spherical face would
// would need to provide its own approximation, as the edges that bound
// it have nothing to do with its curvature.
let exterior = approx_cycle( let exterior = approx_cycle(
face.region().exterior().deref(), face.region().exterior().deref(),
face.surface(), face.surface(),