diff --git a/crates/fj-core/src/algorithms/approx/curve.rs b/crates/fj-core/src/algorithms/approx/curve.rs index 98b759746..88bad2c64 100644 --- a/crates/fj-core/src/algorithms/approx/curve.rs +++ b/crates/fj-core/src/algorithms/approx/curve.rs @@ -299,7 +299,7 @@ mod tests { &core .layers .geometry - .of_surface_2(&surface) + .generator_for_surface(&surface) .unwrap() .geometry, point_surface, @@ -339,7 +339,7 @@ mod tests { &core .layers .geometry - .of_surface_2(&surface) + .generator_for_surface(&surface) .unwrap() .geometry, point_surface, diff --git a/crates/fj-core/src/algorithms/approx/vertex.rs b/crates/fj-core/src/algorithms/approx/vertex.rs index 4112e8bcc..d1f29b9fc 100644 --- a/crates/fj-core/src/algorithms/approx/vertex.rs +++ b/crates/fj-core/src/algorithms/approx/vertex.rs @@ -32,7 +32,7 @@ pub fn approx_vertex( Some(position) => position, None => { let position_global = convert_point_surface_to_global( - &geometry.of_surface_2(surface).unwrap().geometry, + &geometry.generator_for_surface(surface).unwrap().geometry, position_surface, tolerance, geometry, diff --git a/crates/fj-core/src/algorithms/bounding_volume/face.rs b/crates/fj-core/src/algorithms/bounding_volume/face.rs index a52aaa7e2..b4ad98003 100644 --- a/crates/fj-core/src/algorithms/bounding_volume/face.rs +++ b/crates/fj-core/src/algorithms/bounding_volume/face.rs @@ -23,8 +23,10 @@ impl super::BoundingVolume<3> for &Face { (self.region().exterior().deref(), self.surface()) .aabb(geometry) .map(|aabb2| { - let surface = - &geometry.of_surface_2(self.surface()).unwrap().geometry; + let surface = &geometry + .generator_for_surface(self.surface()) + .unwrap() + .geometry; let tri_mesh = surface.generate_tri_mesh(aabb2, tolerance, geometry); let tri_mesh = tri_mesh.into_iter().map(|point| { diff --git a/crates/fj-core/src/algorithms/triangulate/mod.rs b/crates/fj-core/src/algorithms/triangulate/mod.rs index 107f457bb..03fc3f45e 100644 --- a/crates/fj-core/src/algorithms/triangulate/mod.rs +++ b/crates/fj-core/src/algorithms/triangulate/mod.rs @@ -184,7 +184,7 @@ mod tests { &core .layers .geometry - .of_surface_2(&surface) + .generator_for_surface(&surface) .unwrap() .geometry, point, @@ -262,7 +262,7 @@ mod tests { &core .layers .geometry - .of_surface_2(&surface) + .generator_for_surface(&surface) .unwrap() .geometry, point, diff --git a/crates/fj-core/src/geometry/geometry.rs b/crates/fj-core/src/geometry/geometry.rs index 78ccc29d7..b4302bd91 100644 --- a/crates/fj-core/src/geometry/geometry.rs +++ b/crates/fj-core/src/geometry/geometry.rs @@ -214,7 +214,7 @@ impl Geometry { /// method returns the new-style geometry. Its name is temporary, while the /// method returning the old-style geometry is still taking up the more /// concise name. - pub fn of_surface_2( + pub fn generator_for_surface( &self, surface: &Handle, ) -> Option<&SurfaceGeom> { diff --git a/crates/fj-core/src/geometry/surfaces/transformed_surface.rs b/crates/fj-core/src/geometry/surfaces/transformed_surface.rs index 75269ee47..0ad40fcb1 100644 --- a/crates/fj-core/src/geometry/surfaces/transformed_surface.rs +++ b/crates/fj-core/src/geometry/surfaces/transformed_surface.rs @@ -17,7 +17,7 @@ pub struct TransformedSurface { impl GenTriMesh for TransformedSurface { fn origin(&self, geometry: &Geometry) -> Point<3> { - let surface = geometry.of_surface_2(&self.surface).unwrap(); + let surface = geometry.generator_for_surface(&self.surface).unwrap(); self.transform .transform_point(&surface.geometry.origin(geometry)) } @@ -28,7 +28,7 @@ impl GenTriMesh for TransformedSurface { tolerance: Tolerance, geometry: &Geometry, ) -> (Triangle<3>, [Scalar; 3]) { - let surface = geometry.of_surface_2(&self.surface).unwrap(); + let surface = geometry.generator_for_surface(&self.surface).unwrap(); let (triangle, barycentric_coords) = surface .geometry @@ -47,7 +47,7 @@ impl GenTriMesh for TransformedSurface { ) -> Vec> { // The triangle mesh is generated in 2D surface coordinates. No need to // transform that. - let surface = geometry.of_surface_2(&self.surface).unwrap(); + let surface = geometry.generator_for_surface(&self.surface).unwrap(); surface .geometry .generate_tri_mesh(boundary, tolerance, geometry) diff --git a/crates/fj-core/src/operations/holes.rs b/crates/fj-core/src/operations/holes.rs index 811285347..db7f13247 100644 --- a/crates/fj-core/src/operations/holes.rs +++ b/crates/fj-core/src/operations/holes.rs @@ -95,7 +95,7 @@ impl AddHole for Shell { &core .layers .geometry - .of_surface_2(location.face.surface()) + .generator_for_surface(location.face.surface()) .unwrap() .geometry, location.position, diff --git a/crates/fj-core/src/validate/solid.rs b/crates/fj-core/src/validate/solid.rs index b9f53fd43..52adf6641 100644 --- a/crates/fj-core/src/validate/solid.rs +++ b/crates/fj-core/src/validate/solid.rs @@ -117,7 +117,7 @@ impl SolidValidationError { Some(( convert_point_surface_to_global( - &geometry.of_surface_2(s).unwrap().geometry, + &geometry.generator_for_surface(s).unwrap().geometry, local_curve_geometry.path.point_from_path_coords( geometry .of_vertex(h.start_vertex()) diff --git a/crates/fj-core/src/validation/checks/coincident_half_edges_are_not_siblings.rs b/crates/fj-core/src/validation/checks/coincident_half_edges_are_not_siblings.rs index f3f122b9e..c25b3c880 100644 --- a/crates/fj-core/src/validation/checks/coincident_half_edges_are_not_siblings.rs +++ b/crates/fj-core/src/validation/checks/coincident_half_edges_are_not_siblings.rs @@ -229,7 +229,7 @@ fn distances( .path; let surface_coords = path.point_from_path_coords(path_coords); Some(convert_point_surface_to_global( - &geometry.of_surface_2(surface).unwrap().geometry, + &geometry.generator_for_surface(surface).unwrap().geometry, surface_coords, tolerance, geometry,