Refactor

crates/fj-kernel/src/algorithms/transform/cycle.rs

@@ -12,22 +12,11 @@ impl TransformObject for PartialCycle {
         transform: &Transform,
         objects: &Objects,
     ) -> Result<Self, ValidationError> {
-        let surface = self
-            .surface()
-            .map(|surface| surface.transform(transform, objects))
-            .transpose()?;
         let half_edges = self
             .half_edges()
-            .map(|edge| {
+            .map(|edge| edge.into_partial().transform(transform, objects))
-                Ok(edge
-                    .into_partial()
-                    .transform(transform, objects)?
-                    .with_surface(surface.clone()))
-            })
             .collect::<Result<Vec<_>, ValidationError>>()?;
 
-        Ok(Self::default()
+        Ok(Self::default().with_half_edges(half_edges))
-            .with_surface(surface)
-            .with_half_edges(half_edges))
     }
 }

crates/fj-kernel/src/partial/objects/cycle.rs

@@ -1,6 +1,6 @@
 use crate::{
     objects::{Cycle, HalfEdge, Objects, Surface},
-    partial::MaybePartial,
+    partial::{util::merge_options, MaybePartial},
     storage::Handle,
     validate::ValidationError,
 };
@@ -43,9 +43,15 @@ impl PartialCycle {
         mut self,
         half_edges: impl IntoIterator<Item = impl Into<MaybePartial<HalfEdge>>>,
     ) -> Self {
-        self.half_edges
+        let half_edges = half_edges.into_iter().map(Into::into);
-            .extend(half_edges.into_iter().map(Into::into));
+
-        self
+        let mut surface = self.surface();
+        for half_edge in half_edges {
+            surface = merge_options(surface, half_edge.curve().surface());
+            self.half_edges.push(half_edge);
+        }
+
+        self.with_surface(surface)
     }
 
     /// Merge this partial object with another