rei-mirrors/Fornjot
1
0
Fork 0
mirror of https://github.com/hannobraun/Fornjot synced 2025-11-08 08:00:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify SweepSketch

Browse Source 
Remove the more complicated code path, only leaving the simple ones.
This puts more requirements on the caller, which I'm going to document
in a follow-up commit.
This commit is contained in:
Hanno Braun 2024-08-14 19:49:16 +02:00
parent 125c21c7e2
commit a654c93728
1 changed files with 2 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
crates/fj-core/src/operations/sweep/sketch.rs
View File

@ -1,8 +1,7 @@
use fj_math::{Scalar, Vector};
use fj_math::Vector;
use crate::{
geometry::{GlobalPath, SurfaceGeom},
operations::{derive::DeriveFrom, insert::Insert, reverse::Reverse},
operations::insert::Insert,
storage::Handle,
topology::{Face, Sketch, Solid, Surface},
Core,
@ -37,38 +36,6 @@ impl SweepSketch for Sketch {
let mut shells = Vec::new();
for region in self.regions() {
let region = {
// The following code assumes that the sketch is wound counter-
// clockwise. Let's check that real quick.
assert!(region
.exterior()
.winding(&core.layers.geometry, self.surface())
.is_ccw());
let SurfaceGeom::Basic { u, v } =
core.layers.geometry.of_surface(&surface);
let is_negative_sweep = {
let u = match u {
GlobalPath::Circle(_) => todo!(
"Sweeping sketch from a rounded surfaces is not \
supported"
),
GlobalPath::Line(line) => line.direction(),
};
let normal = u.cross(v);
normal.dot(&path) < Scalar::ZERO
};
if is_negative_sweep {
region.clone()
} else {
region.reverse(core).insert(core).derive_from(region, core)
}
};
for cycle in region.all_cycles() {
for half_edge in cycle.half_edges() {
let curve_geom = core