rei-mirrors/Fornjot
1
0
Fork 0
mirror of https://github.com/hannobraun/Fornjot synced 2025-10-04 23:18:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Compute "identical max" based on tolerance

Browse Source
This commit is contained in:
Hanno Braun 2024-08-12 21:53:41 +02:00
parent 682fc6b9dc
commit 8c78e3512a
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
crates/fj-core/src/validation/config.rs
View File

@ -44,10 +44,9 @@ impl ValidationConfig {
pub fn from_tolerance(tolerance: impl Into<Tolerance>) -> Self {
let tolerance = tolerance.into();
// This value was chosen pretty arbitrarily. Seems small enough to catch
// errors. If it turns out it's too small (because it produces false
// positives due to floating-point accuracy issues), we can adjust it.
let identical_max_distance = Scalar::from_f64(5e-14);
// This value can't be smaller than the tolerance. If it is, we'll get
// validation errors everywhere, just from numerical noise.
let identical_max_distance = tolerance.inner() * 10.;
// This value can't be smaller than `identical_max_distance`. Otherwise
// we can have distinct points that satisfy this constraint, but must be